Fix #1064 #1065
Closed
Fix #1064 #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
reviewed
Jul 3, 2023
| @@ -857,19 +865,37 @@ impl WorkerThread { | |||
| } | |||
|
|
|||
| pub(super) fn yield_now(&self) -> Yield { | |||
| let yielding = &self.registry.thread_infos[self.index].is_yielding; | |||
There was a problem hiding this comment.
Seems this could just be a Cell<bool> in WorkerThread (since that's where the thread-local stuff generally lives) instead of living on the registry?
cuviper
requested changes
Jul 3, 2023
| @@ -468,4 +468,7 @@ pub enum Yield { | |||
| Executed, | |||
| /// No available work was found. | |||
| Idle, | |||
| /// Another job that has yielded is already on this thread's stack, so to prevent a stack | |||
| /// overflow we will not start a third job. | |||
| Recursive, | |||
There was a problem hiding this comment.
This is a breaking change, because we didn't make it #[non_exhaustive].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1064 by preventing two jobs on the same thread from yielding at once.