Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] Fix pytest dependency in test_utils #27956

Merged
merged 3 commits into from Aug 17, 2022

Conversation

scv119
Copy link
Contributor

@scv119 scv119 commented Aug 17, 2022

Why are these changes needed?

import pytest in test_utils breaks a bunch of test.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@scv119 scv119 marked this pull request as ready for review August 17, 2022 16:32
@scv119
Copy link
Contributor Author

scv119 commented Aug 17, 2022

waiting for test to pass...

@DmitriGekhtman
Copy link
Contributor

The K8s operator test looks happy!
CI is almost done running....

@scv119 scv119 merged commit 6be4bf8 into ray-project:master Aug 17, 2022
scv119 added a commit that referenced this pull request Aug 17, 2022
import pytest in test_utils breaks a bunch of test.
JiahaoYao pushed a commit to JiahaoYao/ray that referenced this pull request Aug 21, 2022
import pytest in test_utils breaks a bunch of test.
JiahaoYao pushed a commit to JiahaoYao/ray that referenced this pull request Aug 22, 2022
import pytest in test_utils breaks a bunch of test.
JiahaoYao pushed a commit to JiahaoYao/ray that referenced this pull request Aug 22, 2022
import pytest in test_utils breaks a bunch of test.
JiahaoYao pushed a commit to JiahaoYao/ray that referenced this pull request Aug 30, 2022
import pytest in test_utils breaks a bunch of test.
pcmoritz pushed a commit to pcmoritz/ray-1 that referenced this pull request Aug 31, 2022
import pytest in test_utils breaks a bunch of test.

Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
ArturNiederfahrenhorst pushed a commit to ArturNiederfahrenhorst/ray that referenced this pull request Sep 1, 2022
import pytest in test_utils breaks a bunch of test.

Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants