Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Cannot build kuberay with Go 1.16 #568

Closed
2 tasks done
kevin85421 opened this issue Sep 15, 2022 · 2 comments · Fixed by #575
Closed
2 tasks done

[Bug] Cannot build kuberay with Go 1.16 #568

kevin85421 opened this issue Sep 15, 2022 · 2 comments · Fixed by #575
Assignees
Labels
bug Something isn't working

Comments

@kevin85421
Copy link
Member

Search before asking

  • I searched the issues and found no similar issues.

KubeRay Component

ray-operator

What happened + What you expected to happen

My environment: Mac Pro (Intel i5), go1.16.2 darwin/amd64

make build

截圖 2022-09-15 上午11 13 58

This is very similar to kubernetes-sigs/controller-tools#643. Hence, I doubt whether kuberay supports go 1.16 or not. If we cannot, I will update DEVELOPMENT.md.

My Solution: Update to 1.17.6

go install golang.org/dl/go1.17.6@latest
go1.17.6 download
export GOROOT=$(go1.17.6 env GOROOT)
export PATH="$GOROOT/bin:$PATH"
make build

Reproduction script

See above.

Anything else

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@kevin85421 kevin85421 added the bug Something isn't working label Sep 15, 2022
@kevin85421 kevin85421 self-assigned this Sep 15, 2022
@kevin85421
Copy link
Member Author

cc @DmitriGekhtman

@DmitriGekhtman
Copy link
Collaborator

Let's just go the easy route here and assert in Development.MD that KubeRay requires Go 1.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants