forked from openshift/machine-config-operator
-
Notifications
You must be signed in to change notification settings - Fork 0
/
node_controller.go
1044 lines (928 loc) · 35 KB
/
node_controller.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
package node
import (
"context"
"encoding/json"
"fmt"
"reflect"
"time"
"github.com/golang/glog"
configv1 "github.com/openshift/api/config/v1"
cligoinformersv1 "github.com/openshift/client-go/config/informers/externalversions/config/v1"
cligolistersv1 "github.com/openshift/client-go/config/listers/config/v1"
"github.com/openshift/library-go/pkg/operator/v1helpers"
"github.com/openshift/machine-config-operator/internal"
mcfgv1 "github.com/openshift/machine-config-operator/pkg/apis/machineconfiguration.openshift.io/v1"
"github.com/openshift/machine-config-operator/pkg/constants"
ctrlcommon "github.com/openshift/machine-config-operator/pkg/controller/common"
daemonconsts "github.com/openshift/machine-config-operator/pkg/daemon/constants"
mcfgclientset "github.com/openshift/machine-config-operator/pkg/generated/clientset/versioned"
"github.com/openshift/machine-config-operator/pkg/generated/clientset/versioned/scheme"
mcfginformersv1 "github.com/openshift/machine-config-operator/pkg/generated/informers/externalversions/machineconfiguration.openshift.io/v1"
mcfglistersv1 "github.com/openshift/machine-config-operator/pkg/generated/listers/machineconfiguration.openshift.io/v1"
goerrs "github.com/pkg/errors"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/labels"
"k8s.io/apimachinery/pkg/types"
intstrutil "k8s.io/apimachinery/pkg/util/intstr"
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
"k8s.io/apimachinery/pkg/util/strategicpatch"
"k8s.io/apimachinery/pkg/util/wait"
coreinformersv1 "k8s.io/client-go/informers/core/v1"
clientset "k8s.io/client-go/kubernetes"
coreclientsetv1 "k8s.io/client-go/kubernetes/typed/core/v1"
corelisterv1 "k8s.io/client-go/listers/core/v1"
"k8s.io/client-go/tools/cache"
"k8s.io/client-go/tools/record"
clientretry "k8s.io/client-go/util/retry"
"k8s.io/client-go/util/workqueue"
)
const (
// WorkerLabel defines the label associated with worker node.
WorkerLabel = "node-role.kubernetes.io/worker"
// maxRetries is the number of times a machineconfig pool will be retried before it is dropped out of the queue.
// With the current rate-limiter in use (5ms*2^(maxRetries-1)) the following numbers represent the times
// a machineconfig pool is going to be requeued:
//
// 5ms, 10ms, 20ms, 40ms, 80ms, 160ms, 320ms, 640ms, 1.3s, 2.6s, 5.1s, 10.2s, 20.4s, 41s, 82s
maxRetries = 15
// updateDelay is a pause to deal with churn in MachineConfigs; see
// https://github.com/openshift/machine-config-operator/issues/301
updateDelay = 5 * time.Second
// osLabel is used to identify which type of OS the node has
osLabel = "kubernetes.io/os"
// schedulerCRName that we're interested in watching.
schedulerCRName = "cluster"
// masterPoolName is the control plane MachineConfigPool name
masterPoolName = "master"
)
// Controller defines the node controller.
type Controller struct {
client mcfgclientset.Interface
kubeClient clientset.Interface
eventRecorder record.EventRecorder
syncHandler func(mcp string) error
enqueueMachineConfigPool func(*mcfgv1.MachineConfigPool)
ccLister mcfglistersv1.ControllerConfigLister
mcpLister mcfglistersv1.MachineConfigPoolLister
nodeLister corelisterv1.NodeLister
ccListerSynced cache.InformerSynced
mcpListerSynced cache.InformerSynced
nodeListerSynced cache.InformerSynced
schedulerList cligolistersv1.SchedulerLister
schedulerListerSynced cache.InformerSynced
queue workqueue.RateLimitingInterface
}
// New returns a new node controller.
func New(
ccInformer mcfginformersv1.ControllerConfigInformer,
mcpInformer mcfginformersv1.MachineConfigPoolInformer,
nodeInformer coreinformersv1.NodeInformer,
schedulerInformer cligoinformersv1.SchedulerInformer,
kubeClient clientset.Interface,
mcfgClient mcfgclientset.Interface,
) *Controller {
eventBroadcaster := record.NewBroadcaster()
eventBroadcaster.StartLogging(glog.Infof)
eventBroadcaster.StartRecordingToSink(&coreclientsetv1.EventSinkImpl{Interface: kubeClient.CoreV1().Events("")})
ctrl := &Controller{
client: mcfgClient,
kubeClient: kubeClient,
eventRecorder: eventBroadcaster.NewRecorder(scheme.Scheme, corev1.EventSource{Component: "machineconfigcontroller-nodecontroller"}),
queue: workqueue.NewNamedRateLimitingQueue(workqueue.DefaultControllerRateLimiter(), "machineconfigcontroller-nodecontroller"),
}
mcpInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
AddFunc: ctrl.addMachineConfigPool,
UpdateFunc: ctrl.updateMachineConfigPool,
DeleteFunc: ctrl.deleteMachineConfigPool,
})
nodeInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
AddFunc: ctrl.addNode,
UpdateFunc: ctrl.updateNode,
DeleteFunc: ctrl.deleteNode,
})
schedulerInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
AddFunc: ctrl.checkMasterNodesOnAdd,
UpdateFunc: ctrl.checkMasterNodesOnUpdate,
DeleteFunc: ctrl.checkMasterNodesOnDelete,
})
ctrl.syncHandler = ctrl.syncMachineConfigPool
ctrl.enqueueMachineConfigPool = ctrl.enqueueDefault
ctrl.ccLister = ccInformer.Lister()
ctrl.mcpLister = mcpInformer.Lister()
ctrl.nodeLister = nodeInformer.Lister()
ctrl.ccListerSynced = ccInformer.Informer().HasSynced
ctrl.mcpListerSynced = mcpInformer.Informer().HasSynced
ctrl.nodeListerSynced = nodeInformer.Informer().HasSynced
ctrl.schedulerList = schedulerInformer.Lister()
ctrl.schedulerListerSynced = schedulerInformer.Informer().HasSynced
return ctrl
}
// Run executes the render controller.
func (ctrl *Controller) Run(workers int, stopCh <-chan struct{}) {
defer utilruntime.HandleCrash()
defer ctrl.queue.ShutDown()
if !cache.WaitForCacheSync(stopCh, ctrl.ccListerSynced, ctrl.mcpListerSynced, ctrl.nodeListerSynced, ctrl.schedulerListerSynced) {
return
}
glog.Info("Starting MachineConfigController-NodeController")
defer glog.Info("Shutting down MachineConfigController-NodeController")
for i := 0; i < workers; i++ {
go wait.Until(ctrl.worker, time.Second, stopCh)
}
<-stopCh
}
func (ctrl *Controller) getCurrentMasters() ([]*corev1.Node, error) {
nodeList, err := ctrl.nodeLister.List(labels.SelectorFromSet(labels.Set{ctrlcommon.MasterLabel: ""}))
if err != nil {
return nil, fmt.Errorf("error while listing master nodes %v", err)
}
return nodeList, nil
}
// checkMasterNodesOnAdd makes the master nodes schedulable/unschedulable whenever scheduler config CR with name
// cluster is created
func (ctrl *Controller) checkMasterNodesOnAdd(obj interface{}) {
ctrl.reconcileMasters()
}
// checkMasterNodesOnDelete makes the master nodes schedulable/unschedulable whenever scheduler config CR with name
// cluster is created
func (ctrl *Controller) checkMasterNodesOnDelete(obj interface{}) {
scheduler := obj.(*configv1.Scheduler)
if scheduler.Name != schedulerCRName {
glog.V(4).Infof("We don't care about CRs other than cluster created for scheduler config")
return
}
currentMasters, err := ctrl.getCurrentMasters()
if err != nil {
goerrs.Wrap(err, "Reconciling to make master nodes schedulable/unschedulable failed")
return
}
// On deletion make all masters unschedulable to restore default behaviour
errs := ctrl.makeMastersUnSchedulable(currentMasters)
if len(errs) > 0 {
err = v1helpers.NewMultiLineAggregate(errs)
goerrs.Wrap(err, "Reconciling to make nodes schedulable/unschedulable failed")
return
}
return
}
// checkMasterNodesonUpdate makes the master nodes schedulable/unschedulable whenever scheduler
// config CR with name cluster is updated
func (ctrl *Controller) checkMasterNodesOnUpdate(old, cur interface{}) {
oldScheduler := old.(*configv1.Scheduler)
curScheduler := cur.(*configv1.Scheduler)
if oldScheduler.Name != schedulerCRName || curScheduler.Name != schedulerCRName {
glog.V(4).Infof("We don't care about CRs other than cluster created for scheduler config")
return
}
if reflect.DeepEqual(oldScheduler.Spec, curScheduler.Spec) {
glog.V(4).Info("Scheduler config did not change")
return
}
ctrl.reconcileMasters()
}
// makeMastersUnSchedulable makes all the masters in the cluster unschedulable
func (ctrl *Controller) makeMastersUnSchedulable(currentMasters []*corev1.Node) []error {
var errs []error
for _, node := range currentMasters {
if err := ctrl.makeMasterNodeUnSchedulable(node); err != nil {
errs = append(errs, fmt.Errorf("failed making node %v schedulable with error %v", node.Name, err))
}
}
return errs
}
// makeMasterNodeUnSchedulable makes master node unschedulable by removing worker label and adding `NoSchedule`
// master taint to the master node
func (ctrl *Controller) makeMasterNodeUnSchedulable(node *corev1.Node) error {
_, err := internal.UpdateNodeRetry(ctrl.kubeClient.CoreV1().Nodes(), ctrl.nodeLister, node.Name, func(node *corev1.Node) {
// Remove worker label
newLabels := node.Labels
if _, hasWorkerLabel := newLabels[WorkerLabel]; hasWorkerLabel {
delete(newLabels, WorkerLabel)
}
node.Labels = newLabels
// Add master taint
hasMasterTaint := false
for _, taint := range node.Spec.Taints {
if taint.Key == ctrlcommon.MasterLabel && taint.Effect == corev1.TaintEffectNoSchedule {
hasMasterTaint = true
}
}
if !hasMasterTaint {
newTaints := node.Spec.Taints
masterUnSchedulableTaint := corev1.Taint{Key: ctrlcommon.MasterLabel, Effect: corev1.TaintEffectNoSchedule}
newTaints = append(newTaints, masterUnSchedulableTaint)
node.Spec.Taints = newTaints
}
})
if err != nil {
return err
}
return nil
}
// makeMasterNodeSchedulable makes master node schedulable by removing NoSchedule master taint and
// adding worker label
func (ctrl *Controller) makeMasterNodeSchedulable(node *corev1.Node) error {
_, err := internal.UpdateNodeRetry(ctrl.kubeClient.CoreV1().Nodes(), ctrl.nodeLister, node.Name, func(node *corev1.Node) {
// Add worker label
newLabels := node.Labels
if _, hasWorkerLabel := newLabels[WorkerLabel]; !hasWorkerLabel {
newLabels[WorkerLabel] = ""
}
node.Labels = newLabels
// Remove master taint
newTaints := []corev1.Taint{}
for _, t := range node.Spec.Taints {
if t.Key == ctrlcommon.MasterLabel && t.Effect == corev1.TaintEffectNoSchedule {
continue
}
newTaints = append(newTaints, t)
}
node.Spec.Taints = newTaints
})
if err != nil {
return err
}
return nil
}
func (ctrl *Controller) addMachineConfigPool(obj interface{}) {
pool := obj.(*mcfgv1.MachineConfigPool)
glog.V(4).Infof("Adding MachineConfigPool %s", pool.Name)
ctrl.enqueueMachineConfigPool(pool)
}
func (ctrl *Controller) updateMachineConfigPool(old, cur interface{}) {
oldPool := old.(*mcfgv1.MachineConfigPool)
curPool := cur.(*mcfgv1.MachineConfigPool)
glog.V(4).Infof("Updating MachineConfigPool %s", oldPool.Name)
ctrl.enqueueMachineConfigPool(curPool)
}
func (ctrl *Controller) deleteMachineConfigPool(obj interface{}) {
pool, ok := obj.(*mcfgv1.MachineConfigPool)
if !ok {
tombstone, ok := obj.(cache.DeletedFinalStateUnknown)
if !ok {
utilruntime.HandleError(fmt.Errorf("Couldn't get object from tombstone %#v", obj))
return
}
pool, ok = tombstone.Obj.(*mcfgv1.MachineConfigPool)
if !ok {
utilruntime.HandleError(fmt.Errorf("Tombstone contained object that is not a MachineConfigPool %#v", obj))
return
}
}
glog.V(4).Infof("Deleting MachineConfigPool %s", pool.Name)
// TODO(abhinavdahiya): handle deletes.
}
// Determine if masters are currently configured as schedulable
func (ctrl *Controller) getMastersSchedulable() (bool, error) {
schedulerList, err := ctrl.schedulerList.List(labels.SelectorFromSet(nil))
if err != nil {
return false, fmt.Errorf("error while listing scheduler config %v", err)
}
for _, sched := range schedulerList {
if sched.Name == schedulerCRName {
return sched.Spec.MastersSchedulable, nil
}
}
return false, nil
}
// Determine if a given Node is a master
func (ctrl *Controller) isMaster(node *corev1.Node) bool {
_, master := node.ObjectMeta.Labels[ctrlcommon.MasterLabel]
return master
}
// isWindows checks if given node is a Windows node or a Linux node
func isWindows(node *corev1.Node) bool {
windowsOsValue := "windows"
if value, ok := node.ObjectMeta.Labels[osLabel]; ok {
if value == windowsOsValue {
return true
}
return false
}
// All the nodes should have a OS label populated by kubelet, if not just to maintain
// backwards compatibility, we can returning true here.
return false
}
// Given a master Node, ensure it reflects the current mastersSchedulable setting
func (ctrl *Controller) reconcileMaster(node *corev1.Node) {
mastersSchedulable, err := ctrl.getMastersSchedulable()
if err != nil {
goerrs.Wrap(err, "Getting scheduler config failed")
return
}
if mastersSchedulable {
err = ctrl.makeMasterNodeSchedulable(node)
if err != nil {
goerrs.Wrap(err, "Failed making master Node schedulable")
return
}
} else if !mastersSchedulable {
err = ctrl.makeMasterNodeUnSchedulable(node)
if err != nil {
goerrs.Wrap(err, "Failed making master Node unschedulable")
return
}
}
}
// Get a list of current masters and apply scheduler config to them
// TODO: Taint reconciliation should happen elsewhere, in a generic taint/label reconciler
func (ctrl *Controller) reconcileMasters() {
currentMasters, err := ctrl.getCurrentMasters()
if err != nil {
goerrs.Wrap(err, "Reconciling to make master nodes schedulable/unschedulable failed")
return
}
for _, node := range currentMasters {
ctrl.reconcileMaster(node)
}
}
func (ctrl *Controller) addNode(obj interface{}) {
node := obj.(*corev1.Node)
if node.DeletionTimestamp != nil {
ctrl.deleteNode(node)
return
}
if ctrl.isMaster(node) {
ctrl.reconcileMaster(node)
}
pools, err := ctrl.getPoolsForNode(node)
if err != nil {
glog.Errorf("error finding pools for node %s: %v", node.Name, err)
return
}
if pools == nil {
return
}
glog.V(4).Infof("Node %s added", node.Name)
for _, pool := range pools {
ctrl.enqueueMachineConfigPool(pool)
}
}
func (ctrl *Controller) logPool(pool *mcfgv1.MachineConfigPool, format string, args ...interface{}) {
msg := fmt.Sprintf(format, args...)
glog.Infof("Pool %s: %s", pool.Name, msg)
}
func (ctrl *Controller) logPoolNode(pool *mcfgv1.MachineConfigPool, node *corev1.Node, format string, args ...interface{}) {
msg := fmt.Sprintf(format, args...)
glog.Infof("Pool %s: node %s: %s", pool.Name, node.Name, msg)
}
func (ctrl *Controller) updateNode(old, cur interface{}) {
oldNode := old.(*corev1.Node)
curNode := cur.(*corev1.Node)
if !isNodeManaged(curNode) {
return
}
if ctrl.isMaster(curNode) {
ctrl.reconcileMaster(curNode)
}
pool, err := ctrl.getPrimaryPoolForNode(curNode)
if err != nil {
glog.Errorf("error finding pool for node: %v", err)
return
}
if pool == nil {
return
}
glog.V(4).Infof("Node %s updated", curNode.Name)
var changed bool
oldReadyErr := checkNodeReady(oldNode)
newReadyErr := checkNodeReady(curNode)
oldReady := getErrorString(oldReadyErr)
newReady := getErrorString(newReadyErr)
if oldReady != newReady {
changed = true
if newReadyErr != nil {
ctrl.logPoolNode(pool, curNode, "Reporting unready: %v", newReadyErr)
} else {
ctrl.logPoolNode(pool, curNode, "Reporting ready")
}
}
// Specifically log when a node has completed an update so the MCC logs are a useful central aggregate of state changes
if oldNode.Annotations[daemonconsts.CurrentMachineConfigAnnotationKey] != oldNode.Annotations[daemonconsts.DesiredMachineConfigAnnotationKey] &&
isNodeDone(curNode) {
ctrl.logPoolNode(pool, curNode, "Completed update to %s", curNode.Annotations[daemonconsts.DesiredMachineConfigAnnotationKey])
changed = true
} else {
annos := []string{
daemonconsts.CurrentMachineConfigAnnotationKey,
daemonconsts.DesiredMachineConfigAnnotationKey,
daemonconsts.MachineConfigDaemonStateAnnotationKey,
}
for _, anno := range annos {
newValue := curNode.Annotations[anno]
if oldNode.Annotations[anno] != newValue {
ctrl.logPoolNode(pool, curNode, "changed annotation %s = %s", anno, newValue)
changed = true
// For the control plane, emit events for these since they're important
if pool.Name == masterPoolName {
ctrl.eventRecorder.Eventf(pool, corev1.EventTypeNormal, "AnnotationChange", "Node %s now has %s=%s", curNode.Name, anno, newValue)
}
}
}
if !reflect.DeepEqual(oldNode.Labels, curNode.Labels) {
ctrl.logPoolNode(pool, curNode, "changed labels")
changed = true
}
if !reflect.DeepEqual(oldNode.Spec.Taints, curNode.Spec.Taints) {
ctrl.logPoolNode(pool, curNode, "changed taints")
changed = true
}
}
if !changed {
return
}
pools, err := ctrl.getPoolsForNode(curNode)
if err != nil {
glog.Errorf("error finding pools for node: %v", err)
return
}
if pools == nil {
return
}
for _, pool := range pools {
ctrl.enqueueMachineConfigPool(pool)
}
}
func (ctrl *Controller) deleteNode(obj interface{}) {
node, ok := obj.(*corev1.Node)
if !ok {
tombstone, ok := obj.(cache.DeletedFinalStateUnknown)
if !ok {
utilruntime.HandleError(fmt.Errorf("Couldn't get object from tombstone %#v", obj))
return
}
node, ok = tombstone.Obj.(*corev1.Node)
if !ok {
utilruntime.HandleError(fmt.Errorf("Tombstone contained object that is not a Node %#v", obj))
return
}
}
pools, err := ctrl.getPoolsForNode(node)
if err != nil {
glog.Errorf("error finding pools for node: %v", err)
return
}
if pools == nil {
return
}
glog.V(4).Infof("Node %s delete", node.Name)
for _, pool := range pools {
ctrl.enqueueMachineConfigPool(pool)
}
}
// getPoolsForNode chooses the MachineConfigPools that should be used for a given node.
// It disambiguates in the case where e.g. a node has both master/worker roles applied,
// and where a custom role may be used. It returns a slice of all the pools the node belongs to.
// It also ignores the Windows nodes.
func (ctrl *Controller) getPoolsForNode(node *corev1.Node) ([]*mcfgv1.MachineConfigPool, error) {
if isWindows(node) {
// This is not an error, is this a Windows Node and it won't be managed by MCO. We're explicitly logging
// here at a high level to disambiguate this from other pools = nil scenario
glog.V(4).Infof("Node %v is a windows node so won't be managed by MCO", node.Name)
return nil, nil
}
pl, err := ctrl.mcpLister.List(labels.Everything())
if err != nil {
return nil, err
}
var pools []*mcfgv1.MachineConfigPool
for _, p := range pl {
selector, err := metav1.LabelSelectorAsSelector(p.Spec.NodeSelector)
if err != nil {
return nil, fmt.Errorf("invalid label selector: %v", err)
}
// If a pool with a nil or empty selector creeps in, it should match nothing, not everything.
if selector.Empty() || !selector.Matches(labels.Set(node.Labels)) {
continue
}
pools = append(pools, p)
}
if len(pools) == 0 {
// This is not an error, as there might be nodes in cluster that are not managed by machineconfigpool.
return nil, nil
}
var master, worker *mcfgv1.MachineConfigPool
var custom []*mcfgv1.MachineConfigPool
for _, pool := range pools {
if pool.Name == masterPoolName {
master = pool
} else if pool.Name == "worker" {
worker = pool
} else {
custom = append(custom, pool)
}
}
if len(custom) > 1 {
return nil, fmt.Errorf("node %s belongs to %d custom roles, cannot proceed with this Node", node.Name, len(custom))
} else if len(custom) == 1 {
// We don't support making custom pools for masters
if master != nil {
return nil, fmt.Errorf("node %s has both master role and custom role %s", node.Name, custom[0].Name)
}
// One custom role, let's use its pool
pls := []*mcfgv1.MachineConfigPool{custom[0]}
if worker != nil {
pls = append(pls, worker)
}
return pls, nil
} else if master != nil {
// In the case where a node is both master/worker, have it live under
// the master pool. This occurs in CodeReadyContainers and general
// "single node" deployments, which one may want to do for testing bare
// metal, etc.
return []*mcfgv1.MachineConfigPool{master}, nil
}
// Otherwise, it's a worker with no custom roles.
return []*mcfgv1.MachineConfigPool{worker}, nil
}
// getPrimaryPoolForNode uses getPoolsForNode and returns the first one which is the one the node targets
func (ctrl *Controller) getPrimaryPoolForNode(node *corev1.Node) (*mcfgv1.MachineConfigPool, error) {
pools, err := ctrl.getPoolsForNode(node)
if err != nil {
return nil, err
}
if pools == nil {
return nil, nil
}
return pools[0], nil
}
func (ctrl *Controller) enqueue(pool *mcfgv1.MachineConfigPool) {
key, err := cache.DeletionHandlingMetaNamespaceKeyFunc(pool)
if err != nil {
utilruntime.HandleError(fmt.Errorf("Couldn't get key for object %#v: %v", pool, err))
return
}
ctrl.queue.Add(key)
}
func (ctrl *Controller) enqueueRateLimited(pool *mcfgv1.MachineConfigPool) {
key, err := cache.DeletionHandlingMetaNamespaceKeyFunc(pool)
if err != nil {
utilruntime.HandleError(fmt.Errorf("Couldn't get key for object %#v: %v", pool, err))
return
}
ctrl.queue.AddRateLimited(key)
}
// enqueueAfter will enqueue a pool after the provided amount of time.
func (ctrl *Controller) enqueueAfter(pool *mcfgv1.MachineConfigPool, after time.Duration) {
key, err := cache.DeletionHandlingMetaNamespaceKeyFunc(pool)
if err != nil {
utilruntime.HandleError(fmt.Errorf("Couldn't get key for object %#v: %v", pool, err))
return
}
ctrl.queue.AddAfter(key, after)
}
// enqueueDefault calls a default enqueue function
func (ctrl *Controller) enqueueDefault(pool *mcfgv1.MachineConfigPool) {
ctrl.enqueueAfter(pool, updateDelay)
}
// worker runs a worker thread that just dequeues items, processes them, and marks them done.
// It enforces that the syncHandler is never invoked concurrently with the same key.
func (ctrl *Controller) worker() {
for ctrl.processNextWorkItem() {
}
}
func (ctrl *Controller) processNextWorkItem() bool {
key, quit := ctrl.queue.Get()
if quit {
return false
}
defer ctrl.queue.Done(key)
err := ctrl.syncHandler(key.(string))
ctrl.handleErr(err, key)
return true
}
func (ctrl *Controller) handleErr(err error, key interface{}) {
if err == nil {
ctrl.queue.Forget(key)
return
}
if ctrl.queue.NumRequeues(key) < maxRetries {
glog.V(2).Infof("Error syncing machineconfigpool %v: %v", key, err)
ctrl.queue.AddRateLimited(key)
return
}
utilruntime.HandleError(err)
glog.V(2).Infof("Dropping machineconfigpool %q out of the queue: %v", key, err)
ctrl.queue.Forget(key)
ctrl.queue.AddAfter(key, 1*time.Minute)
}
// syncMachineConfigPool will sync the machineconfig pool with the given key.
// This function is not meant to be invoked concurrently with the same key.
func (ctrl *Controller) syncMachineConfigPool(key string) error {
startTime := time.Now()
glog.V(4).Infof("Started syncing machineconfigpool %q (%v)", key, startTime)
defer func() {
glog.V(4).Infof("Finished syncing machineconfigpool %q (%v)", key, time.Since(startTime))
}()
_, name, err := cache.SplitMetaNamespaceKey(key)
if err != nil {
return err
}
machineconfigpool, err := ctrl.mcpLister.Get(name)
if errors.IsNotFound(err) {
glog.V(2).Infof("MachineConfigPool %v has been deleted", key)
return nil
}
if err != nil {
return err
}
if machineconfigpool.Spec.Configuration.Name == "" {
// Previously we spammed the logs about empty pools.
// Let's just pause for a bit here to let the renderer
// initialize them.
glog.Infof("Pool %s is unconfigured, pausing %v for renderer to initialize", name, updateDelay)
time.Sleep(updateDelay)
return nil
}
// Deep-copy otherwise we are mutating our cache.
// TODO: Deep-copy only when needed.
pool := machineconfigpool.DeepCopy()
everything := metav1.LabelSelector{}
if reflect.DeepEqual(pool.Spec.NodeSelector, &everything) {
ctrl.eventRecorder.Eventf(pool, corev1.EventTypeWarning, "SelectingAll", "This machineconfigpool is selecting all nodes. A non-empty selector is required.")
return nil
}
if pool.DeletionTimestamp != nil {
return ctrl.syncStatusOnly(pool)
}
if pool.Spec.Paused {
if mcfgv1.IsMachineConfigPoolConditionTrue(pool.Status.Conditions, mcfgv1.MachineConfigPoolUpdating) {
glog.Infof("Pool %s is paused and will not update.", pool.Name)
}
return ctrl.syncStatusOnly(pool)
}
nodes, err := ctrl.getNodesForPool(pool)
if err != nil {
if syncErr := ctrl.syncStatusOnly(pool); syncErr != nil {
return goerrs.Wrapf(err, "error getting nodes for pool %q, sync error: %v", pool.Name, syncErr)
}
return err
}
maxunavail, err := maxUnavailable(pool, nodes)
if err != nil {
if syncErr := ctrl.syncStatusOnly(pool); syncErr != nil {
return goerrs.Wrapf(err, "error getting max unavailable count for pool %q, sync error: %v", pool.Name, syncErr)
}
return err
}
if err := ctrl.setClusterConfigAnnotation(nodes); err != nil {
return goerrs.Wrapf(err, "error setting clusterConfig Annotation for node in pool %q, error: %v", pool.Name, err)
}
// Taint all the nodes in the node pool, irrespective of their upgrade status.
ctx := context.TODO()
for _, node := range nodes {
// All the nodes that need to be upgraded should have `NodeUpdateInProgressTaint` so that they're less likely
// to be chosen during the scheduling cycle.
targetConfig := pool.Spec.Configuration.Name
if node.Annotations[daemonconsts.DesiredMachineConfigAnnotationKey] != targetConfig {
if err := ctrl.setUpdateInProgressTaint(ctx, node.Name); err != nil {
return goerrs.Wrapf(err, "failed applying %s taint for node %s", constants.NodeUpdateInProgressTaint.Key, node.Name)
}
}
}
candidates, capacity := getAllCandidateMachines(pool, nodes, maxunavail)
if len(candidates) > 0 {
ctrl.logPool(pool, "%d candidate nodes for update, capacity: %d", len(candidates), capacity)
if err := ctrl.updateCandidateMachines(pool, candidates, capacity); err != nil {
if syncErr := ctrl.syncStatusOnly(pool); syncErr != nil {
return goerrs.Wrapf(err, "error setting desired machine config annotation for pool %q, sync error: %v", pool.Name, syncErr)
}
return err
}
}
return ctrl.syncStatusOnly(pool)
}
func (ctrl *Controller) getNodesForPool(pool *mcfgv1.MachineConfigPool) ([]*corev1.Node, error) {
selector, err := metav1.LabelSelectorAsSelector(pool.Spec.NodeSelector)
if err != nil {
return nil, fmt.Errorf("invalid label selector: %v", err)
}
initialNodes, err := ctrl.nodeLister.List(selector)
if err != nil {
return nil, err
}
nodes := []*corev1.Node{}
for _, n := range initialNodes {
p, err := ctrl.getPrimaryPoolForNode(n)
if err != nil {
glog.Warningf("can't get pool for node %q: %v", n.Name, err)
continue
}
if p == nil {
continue
}
if p.Name != pool.Name {
continue
}
nodes = append(nodes, n)
}
return nodes, nil
}
// setClusterConfigAnnotation reads cluster configs set into controllerConfig
// and add/updates required annotation to node such as ControlPlaneTopology
// from infrastructure object.
func (ctrl *Controller) setClusterConfigAnnotation(nodes []*corev1.Node) error {
cc, err := ctrl.ccLister.Get(ctrlcommon.ControllerConfigName)
if err != nil {
return err
}
for _, node := range nodes {
if node.Annotations[daemonconsts.ClusterControlPlaneTopologyAnnotationKey] != string(cc.Spec.Infra.Status.ControlPlaneTopology) {
oldAnn := node.Annotations[daemonconsts.ClusterControlPlaneTopologyAnnotationKey]
_, err := internal.UpdateNodeRetry(ctrl.kubeClient.CoreV1().Nodes(), ctrl.nodeLister, node.Name, func(node *corev1.Node) {
node.Annotations[daemonconsts.ClusterControlPlaneTopologyAnnotationKey] = string(cc.Spec.Infra.Status.ControlPlaneTopology)
})
if err != nil {
return err
}
glog.Infof("Updated controlPlaneTopology annotation of node %s from %s to %s", node.Name, oldAnn, node.Annotations[daemonconsts.ClusterControlPlaneTopologyAnnotationKey])
}
}
return nil
}
func (ctrl *Controller) setDesiredMachineConfigAnnotation(nodeName, currentConfig string) error {
return clientretry.RetryOnConflict(constants.NodeUpdateBackoff, func() error {
oldNode, err := ctrl.kubeClient.CoreV1().Nodes().Get(context.TODO(), nodeName, metav1.GetOptions{})
if err != nil {
return err
}
oldData, err := json.Marshal(oldNode)
if err != nil {
return err
}
newNode := oldNode.DeepCopy()
if newNode.Annotations == nil {
newNode.Annotations = map[string]string{}
}
if newNode.Annotations[daemonconsts.DesiredMachineConfigAnnotationKey] == currentConfig {
return nil
}
newNode.Annotations[daemonconsts.DesiredMachineConfigAnnotationKey] = currentConfig
newData, err := json.Marshal(newNode)
if err != nil {
return err
}
patchBytes, err := strategicpatch.CreateTwoWayMergePatch(oldData, newData, corev1.Node{})
if err != nil {
return fmt.Errorf("failed to create patch for node %q: %v", nodeName, err)
}
_, err = ctrl.kubeClient.CoreV1().Nodes().Patch(context.TODO(), nodeName, types.StrategicMergePatchType, patchBytes, metav1.PatchOptions{})
return err
})
}
// getAllCandidateMachines returns all possible nodes which can be updated to the target config, along with a maximum
// capacity. It is the reponsibility of the caller to choose a subset of the nodes given the capacity.
func getAllCandidateMachines(pool *mcfgv1.MachineConfigPool, nodesInPool []*corev1.Node, maxUnavailable int) ([]*corev1.Node, uint) {
targetConfig := pool.Spec.Configuration.Name
unavail := getUnavailableMachines(nodesInPool)
// If we're at capacity, there's nothing to do.
if len(unavail) >= maxUnavailable {
return nil, 0
}
capacity := maxUnavailable - len(unavail)
failingThisConfig := 0
// We only look at nodes which aren't already targeting our desired config
var nodes []*corev1.Node
for _, node := range nodesInPool {
if node.Annotations[daemonconsts.DesiredMachineConfigAnnotationKey] == targetConfig {
if isNodeMCDFailing(node) {
failingThisConfig++
}
continue
}
nodes = append(nodes, node)
}
// Nodes which are failing to target this config also count against
// availability - it might be a transient issue, and if the issue
// clears we don't want multiple to update at once.
if failingThisConfig >= capacity {
return nil, 0
}
capacity -= failingThisConfig
return nodes, uint(capacity)
}
// getCandidateMachines returns the maximum subset of nodes which can be updated to the target config given availability constraints.
func getCandidateMachines(pool *mcfgv1.MachineConfigPool, nodesInPool []*corev1.Node, maxUnavailable int) []*corev1.Node {
nodes, capacity := getAllCandidateMachines(pool, nodesInPool, maxUnavailable)
if uint(len(nodes)) < capacity {
return nodes
}
return nodes[:capacity]
}
// getCurrentEtcdLeader is not yet implemented
func (ctrl *Controller) getCurrentEtcdLeader(candidates []*corev1.Node) (*corev1.Node, error) {
return nil, nil
}
// filterControlPlaneCandidateNodes adjusts the candidates and capacity specifically
// for the control plane, e.g. based on which node is the etcd leader at the time.
// nolint:unparam
func (ctrl *Controller) filterControlPlaneCandidateNodes(pool *mcfgv1.MachineConfigPool, candidates []*corev1.Node, capacity uint) ([]*corev1.Node, uint, error) {
if len(candidates) <= 1 {
return candidates, capacity, nil
}
etcdLeader, err := ctrl.getCurrentEtcdLeader(candidates)
if err != nil {
glog.Warningf("Failed to find current etcd leader (continuing anyways): %v", err)
}
var newCandidates []*corev1.Node
for _, node := range candidates {
if node == etcdLeader {
// For now make this an event so we know it's working, even though it's more of a non-event
ctrl.eventRecorder.Eventf(pool, corev1.EventTypeNormal, "DeferringEtcdLeaderUpdate", "Deferring update of etcd leader %s", node.Name)
glog.Infof("Deferring update of etcd leader: %s", node.Name)
continue
}
newCandidates = append(newCandidates, node)
}
return newCandidates, capacity, nil
}
// updateCandidateMachines sets the desiredConfig annotation the candidate machines
func (ctrl *Controller) updateCandidateMachines(pool *mcfgv1.MachineConfigPool, candidates []*corev1.Node, capacity uint) error {
if pool.Name == masterPoolName {
var err error
candidates, capacity, err = ctrl.filterControlPlaneCandidateNodes(pool, candidates, capacity)
if err != nil {
return err
}
// In practice right now these counts will be 1 but let's stay general to support 5 etcd nodes in the future
ctrl.logPool(pool, "filtered to %d candidate nodes for update, capacity: %d", len(candidates), capacity)
}
if capacity < uint(len(candidates)) {
// Arbitrarily pick the first N candidates; no attempt at sorting.
// Perhaps later we allow admins to weight somehow, or do something more intelligent.
candidates = candidates[:capacity]
}
targetConfig := pool.Spec.Configuration.Name
for _, node := range candidates {
ctrl.logPool(pool, "Setting node %s target to %s", node.Name, targetConfig)
if err := ctrl.setDesiredMachineConfigAnnotation(node.Name, targetConfig); err != nil {
return goerrs.Wrapf(err, "setting desired config for node %s", node.Name)
}
}
if len(candidates) == 1 {
candidate := candidates[0]
ctrl.eventRecorder.Eventf(pool, corev1.EventTypeNormal, "SetDesiredConfig", "Targeted node %s to config %s", candidate.Name, targetConfig)
} else {
ctrl.eventRecorder.Eventf(pool, corev1.EventTypeNormal, "SetDesiredConfig", "Set target for %d nodes to config %s", targetConfig)
}
return nil
}
// setUpdateInProgressTaint applies in progress taint to all the nodes that are to be updated.
// The taint on the individual node is removed by MCD once the update of the node is complete.
// This is to ensure that the updated nodes are being preferred to non-updated nodes there by
// reducing the number of reschedules.
func (ctrl *Controller) setUpdateInProgressTaint(ctx context.Context, nodeName string) error {
return clientretry.RetryOnConflict(constants.NodeUpdateBackoff, func() error {
oldNode, err := ctrl.kubeClient.CoreV1().Nodes().Get(ctx, nodeName, metav1.GetOptions{})
if err != nil {
return err
}
oldData, err := json.Marshal(oldNode)
if err != nil {
return err
}
newNode := oldNode.DeepCopy()
if newNode.Spec.Taints == nil {
newNode.Spec.Taints = []corev1.Taint{}
}