-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backend] Db Server Stats #32
[Backend] Db Server Stats #32
Conversation
Fixed setting 'checkbox' custom fields for backlog items
@AKlaus created as draft at-the-moment since I haven't fully tested it yet. You can go ahead and provide any remarks if you want. |
Hi @yj7o5,
|
{ | ||
[ApiController] | ||
[Route("api/[controller]")] | ||
public class AdminController : ControllerBase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please name the controller Stats
.
There aren't going to be any "admin" features.
/// <summary> | ||
/// Get various database stats such as memory, cpu usage, etc. | ||
/// </summary> | ||
[HttpGet("database-stats")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the controller is renamed, then the end-point can be called database
|
||
public int CountOfIndexes { get; set; } | ||
|
||
public long CountOfDocuments { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an option to add SizeOnDisk
property as well?
3. Import test data from `/documentation/exported_data.ravendbdump` file ([see the docs](https://ravendb.net/docs/article-page/latest/csharp/studio/database/tasks/import-data/import-data-file)) | ||
4. Set the address to the _RavenDB_ server and the DB name in `./back-end/WebApi/appsettings.Development.json`. | ||
4. Set the address to the _RavenDB_ server and the DB name in `./back-end/WebApi/appsettings.Development.json`. The database config follows the structure specified in [DatabaseSettings.cs](./back-end/Database/DataBase.Common/Configuration/DatabaseSettings.cs). As an example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's be concise, no one reads long text.
Suggested wording:
Set the address to the RavenDB server and the DB name in
./back-end/WebApi/appsettings.Development.json
(propertiesDatabase.RavenDbUrls
,RavenDbUrls.DbName
).
The rest of the config is not applicable here
services.AddHttpClient<IRavenService, RavenService>((serviceProvider, client) => | ||
{ | ||
var dbSettings = serviceProvider.GetService<DatabaseSettings>(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it require authentication on the RavenDB server? (I understand that it's not required on the dev instance)
Can we hijack the current connection? (it would be especially handy for tests). Check out this link.
Thanks @AKlaus will go ahead and perform the changes. |
Closing it, as it appears abandoned by the submitter (idle for more than a year) |
partially closes #10