Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add missing tests for #182 #184

Merged
merged 1 commit into from Mar 20, 2019
Merged

test: add missing tests for #182 #184

merged 1 commit into from Mar 20, 2019

Conversation

silkentrance
Copy link
Collaborator

@silkentrance silkentrance commented Jan 12, 2019

chore: update rimraf to latest version
chore: remove duplicate dependencies section from package.json

@silkentrance
Copy link
Collaborator Author

See also #182, #183

Copy link
Owner

@raszi raszi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I believe the .endsWith express our intention better.

test/file-sync-test.js Outdated Show resolved Hide resolved
test/file-test.js Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@raszi raszi changed the title Add missing tests for #182 test: add missing tests for #182 Jan 31, 2019
@silkentrance silkentrance requested a review from raszi March 16, 2019 14:15
@silkentrance
Copy link
Collaborator Author

Merging now, as all change requests have been met.

@silkentrance silkentrance merged commit 84cea56 into master Mar 20, 2019
@silkentrance silkentrance deleted the gh-182 branch March 20, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants