Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Consider making the lock types of memory resources private #1331

Open
vyasr opened this issue Aug 30, 2023 · 0 comments
Open

[FEA] Consider making the lock types of memory resources private #1331

vyasr opened this issue Aug 30, 2023 · 0 comments
Labels
? - Needs Triage Need team to review and classify feature request New feature or request good first issue Good for newcomers

Comments

@vyasr
Copy link
Contributor

vyasr commented Aug 30, 2023

Is your feature request related to a problem? Please describe.
Classes like fixed_size_memory_resource define a lock type as a protected member. This exposes an implementation detail of the class that may not need to be visible to subclasses.

Describe the solution you'd like
We should investigate making these attributes private instead of public. c.f. #1317 (comment)
@vyasr vyasr added feature request New feature or request ? - Needs Triage Need team to review and classify labels Aug 30, 2023
@vyasr vyasr mentioned this issue Aug 30, 2023
Merged
3 tasks
@harrism harrism added the good first issue Good for newcomers label Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
? - Needs Triage Need team to review and classify feature request New feature or request good first issue Good for newcomers
Projects
RMM Project Board
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@harrism @vyasr