Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Stop allowing floating arrow along minor versions #15754

Closed
vyasr opened this issue May 14, 2024 · 0 comments · Fixed by #15755
Closed

[BUG] Stop allowing floating arrow along minor versions #15754

vyasr opened this issue May 14, 2024 · 0 comments · Fixed by #15755
Labels
bug Something isn't working

Comments

@vyasr
Copy link
Contributor

vyasr commented May 14, 2024

Describe the bug
Currently the logic for finding libarrow searches for a libarrow with the name libarrow.so.${MAJOR_VERSION}00. The code states that this is because the last two digits are always just 00, regardless of minor version. However, prior to now we have never seen a minor version of pyarrow, only patch versions and major versions. Therefore, this logic was probably never quite right, but it was based on the only data we had to go on at the time. With the recent release of pyarrow 16.1, we know that this logic is incorrect and need to adjust accordingly.

Moreover, previously we believed that it would be possible to interchange different minor versions of the arrow library within the same major family. Since the SONAME of the library changed with the minor version, though, that does not seem to be the case. As a result, we will have to pin the runtime dependency of arrow to stick to the current minor version.

Expected behavior
We should adjust the logic to search for the library according to the proper SOVERSION as constructed by arrow, which means adding in the two-digit padded minor version to the major version.

@vyasr vyasr added the bug Something isn't working label May 14, 2024
@vyasr vyasr changed the title [BUG] Cmake logic for finding libarrow in pyarrow is incorrect [BUG] Stop allowing floating arrow along minor versions May 14, 2024
@vyasr vyasr mentioned this issue May 14, 2024
3 tasks
rapids-bot bot pushed a commit that referenced this issue May 15, 2024
Resolves #15754

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - GALI PREM SAGAR (https://github.com/galipremsagar)

URL: #15755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant