Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Migrate left join and conditional join benchmarks to use nvbench #15699

Open
3 tasks
PointKernel opened this issue May 7, 2024 · 0 comments
Open
3 tasks
Assignees
Labels
feature request New feature or request good first issue Good for newcomers libcudf Affects libcudf (C++/CUDA) code.

Comments

@PointKernel
Copy link
Member

Is your feature request related to a problem? Please describe.
The current left join and conditional join benchmarks are still using gbench. We should migrate them to use nvbench for simplicity and consistency.

Describe the solution you'd like

TODO:

  • Migrate from gbench to nvbench
  • Similar to Clean up join benchmarks #15644, use JOIN_KEY_TYPE_RANGE, JOIN_NULLABLE_RANGE and JOIN_SIZE_RANGE to reduce the number of test cases and simplify the implementation
  • Get rid of the dispatching between gbench and nvbench in join_common.hpp
@PointKernel PointKernel added feature request New feature or request 0 - Backlog In queue waiting for assignment good first issue Good for newcomers libcudf Affects libcudf (C++/CUDA) code. labels May 7, 2024
@PointKernel PointKernel removed the 0 - Backlog In queue waiting for assignment label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request good first issue Good for newcomers libcudf Affects libcudf (C++/CUDA) code.
Projects
Status: In Progress
Development

No branches or pull requests

3 participants
@PointKernel @srinivasyadav18 and others