Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] pylibcudf strings circular import error #15689

Closed
er-eis opened this issue May 7, 2024 · 1 comment · Fixed by #15691
Closed

[BUG] pylibcudf strings circular import error #15689

er-eis opened this issue May 7, 2024 · 1 comment · Fixed by #15691
Labels
bug Something isn't working

Comments

@er-eis
Copy link
Contributor

er-eis commented May 7, 2024

Looks like this CI/CD run was mostly skipped -- https://github.com/rapidsai/cudf/actions/runs/8977241037/job/24655609146

Getting circular import issues. pytests were running in pycharm just fine before I pulled this change in. Also tried using CLI pytest and getting same circular import error

(cudf_dev)  ✘ administrator@administrator-laptop  ~/programming/cudf  ↱ branch-24.06  git pull upstream branch-24.06
From github.com:rapidsai/cudf
 * branch                  branch-24.06 -> FETCH_HEAD
Already up to date.
(cudf_dev)  administrator@administrator-laptop  ~/programming/cudf  ↱ branch-24.06  pytest -v ./python/cudf/cudf/tests
/home/administrator/miniconda3/envs/cudf_dev/lib/python3.11/site-packages/_pytest/config/__init__.py:331: PluggyTeardownRaisedWarning: A plugin raised an exception during an old-style hookwrapper teardown.
Plugin: helpconfig, Hook: pytest_cmdline_parse
ConftestImportFailure: ImportError: cannot import name 'find' from partially initialized module 'cudf._lib.pylibcudf.strings' (most likely due to a circular import) (/home/administrator/programming/cudf/python/cudf/cudf/_lib/pylibcudf/strings/__init__.py) (from /home/administrator/programming/cudf/python/cudf/cudf/tests/conftest.py)
For more information see https://pluggy.readthedocs.io/en/stable/api_reference.html#pluggy.PluggyTeardownRaisedWarning
  config = pluginmanager.hook.pytest_cmdline_parse(
ImportError while loading conftest '/home/administrator/programming/cudf/python/cudf/cudf/tests/conftest.py'.
python/cudf/cudf/tests/conftest.py:13: in <module>
    import cudf
python/cudf/cudf/__init__.py:9: in <module>
    _setup_numba()
python/cudf/cudf/utils/_numba.py:124: in _setup_numba
    _get_cc_60_ptx_file()
python/cudf/cudf/utils/_numba.py:16: in _get_cc_60_ptx_file
    from cudf._lib import strings_udf
python/cudf/cudf/_lib/__init__.py:4: in <module>
    from . import (
avro.pyx:1: in init cudf._lib.avro
    ???
column.pyx:1: in init cudf._lib.column
    ???
python/cudf/cudf/_lib/pylibcudf/__init__.py:3: in <module>
    from . import (
python/cudf/cudf/_lib/pylibcudf/strings/__init__.py:3: in <module>
    from . import case, find
E   ImportError: cannot import name 'find' from partially initialized module 'cudf._lib.pylibcudf.strings' (most likely due to a circular import) (/home/administrator/programming/cudf/python/cudf/cudf/_lib/pylibcudf/strings/__init__.py)
@er-eis er-eis added the bug Something isn't working label May 7, 2024
@er-eis er-eis changed the title [BUG] circular import error [BUG] pylibcudf strings circular import error May 7, 2024
@er-eis
Copy link
Contributor Author

er-eis commented May 7, 2024

this was resolved by re-running the build script:

./build.sh --pydevelop libcudf libcudf_kafka cudf dask_cudf cudf_kafka custreamz

@er-eis er-eis mentioned this issue May 7, 2024
Merged
2 tasks
rapids-bot bot pushed a commit that referenced this issue May 21, 2024
@er-eis
Add contributing warning about circular imports (#15691)
70922d0 
Closes #15689 

Adds warning to contributing doc regarding the necessity to rebuild and the type of error a developer may see

Authors:
  - https://github.com/er-eis

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - GALI PREM SAGAR (https://github.com/galipremsagar)

URL: #15691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
cuDF/Dask/Numba/UCX
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add contributing warning about circular imports er-eis/cudf
2 participants
@er-eis and others