Don't proxy non-bound class functions in cudf.pandas #15646
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #15637
If a user has code like
cudf.pandas
will attempt to proxyFoo.__init__
as an unbound function. Unfortunately when this method is called i.e.Foo(2)
we are unable to pass the instance along,self
, and call this asFoo.__init__(2)
.I'm unsure how we would be able to pass the instance along, so for now I am avoiding proxying these functions (by hackily checking for
self
in the signature). Open to better solutionsChecklist