Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the current status of features to the debug command output #18793

Closed
dwelch-r7 opened this issue Feb 6, 2024 · 1 comment · Fixed by #19172
Closed

Add the current status of features to the debug command output #18793

dwelch-r7 opened this issue Feb 6, 2024 · 1 comment · Fixed by #19172
Assignees
@cgranleese-r7
Labels
suggestion-feature New feature suggestions

Comments

@dwelch-r7
Copy link
Contributor

dwelch-r7 commented Feb 6, 2024 •
edited by adfoster-r7

Realised when looking at #18791 that the debug command output doesn't have the feature flag status included
We should add another section to the debug command output containing something similar to the output of the features command within msfconsole

## Framework config

The following framework config was set before the issue occurred:

<details>
<summary>Collapse</summary>

```
Features
========

   #   Name                         Enabled
   -   ----                         -------
   0   wrapped_tables               true
   1   fully_interactive_shells     false
   2   manager_commands             true 
   3   datastore_fallbacks          true 
   4   metasploit_payload_warnings  true 
   5   defer_module_loads           false
   6   smb_session_type             true 
   7   postgresql_session_type      false
   8   mysql_session_type           false
   9   dns_feature                  true 
   10  hierarchical_search_table    true
```
</details>

This will be particularly useful when trying to replicate issues that may or may not be affected by a feature flag (in the case of #18791 the error only occurs when defer_module_loads is set to false for example)
@dwelch-r7 dwelch-r7 added the suggestion-feature New feature suggestions label Feb 6, 2024
@snehalchaudhari98
Copy link

Hi! I want to try to fix the issue. It's the first time I'm contributing to an open-source project, so I think I would be able to fix it and contribute something. Could you please assign this issue to me?

@cgranleese-r7 cgranleese-r7 mentioned this issue May 8, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgranleese-r7 cgranleese-r7

Labels
suggestion-feature New feature suggestions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds the features configuration to the debug command output cgranleese-r7/metasploit-framework
3 participants
@dwelch-r7 @snehalchaudhari98 @cgranleese-r7