Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook duo-theme preview adds accessibility violations #80

Open
t-schemmer opened this issue Jul 23, 2020 · 0 comments
Open

Storybook duo-theme preview adds accessibility violations #80

t-schemmer opened this issue Jul 23, 2020 · 0 comments
Labels
a11y Accessibility concerns or requests kit: Storybook Concerning Storybook status: needs triage These issues haven't been looked at yet by a maintainer.

Comments

@t-schemmer
Copy link
Collaborator

Storybook's preview contains blocks to show both themes (light and dark) at the same time. If a developer creates a component with an IDREF, they will be duplicated, which the accessibility-plugin will detect as a violation.

Thoughts

  • Create a theme toggle plugin (on a Storybook Panel)
  • Use an existing plugin to toggle the theme
  • Create a toggle as a knob

Notes

  • Sometimes it necessary to implement static or dynamic IDREF's for Accessibility purposes (e.g. using aria-labelledby or aria-describedby). Even generated IDREF's within the component can still contribute to issue described above.
@t-schemmer t-schemmer added status: needs triage These issues haven't been looked at yet by a maintainer. a11y Accessibility concerns or requests kit: Storybook Concerning Storybook labels Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a11y Accessibility concerns or requests kit: Storybook Concerning Storybook status: needs triage These issues haven't been looked at yet by a maintainer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@t-schemmer