Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prop Bleeding to HTML attribs. #75

Open
t-schemmer opened this issue Jul 2, 2020 · 2 comments
Open

Prop Bleeding to HTML attribs. #75

t-schemmer opened this issue Jul 2, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@t-schemmer
Copy link
Collaborator

In some cases when providing props to components, there is some non-compliant html attribute bleeding.
e.g.
display is passed to the html node because it's not destructured from the props before being passed to children.

Perhaps making use of shouldForwardProp will remedy this, and keep the HTML compliant.
@t-schemmer t-schemmer added question Further information is requested status: needs triage These issues haven't been looked at yet by a maintainer. labels Jul 2, 2020
@winkerVSbecks
Copy link
Contributor

Thank you. Was waiting for that PR to be merged.

@tylervipond tylervipond added enhancement New feature or request bug Something isn't working and removed status: needs triage These issues haven't been looked at yet by a maintainer. enhancement New feature or request question Further information is requested labels Jul 16, 2020
@tylervipond
Copy link

changing this into a bug at this point, as this is fixable, and should be low risk to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@winkerVSbecks @tylervipond @t-schemmer