Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RKE - Add support for provisioning 1.24 clusters #2936

Closed
9 tasks done
jiaqiluo opened this issue May 13, 2022 · 7 comments
Closed
9 tasks done

RKE - Add support for provisioning 1.24 clusters #2936

jiaqiluo opened this issue May 13, 2022 · 7 comments
Assignees
Milestone

Comments

@jiaqiluo
Copy link
Member

jiaqiluo commented May 13, 2022

K8S 1.24 was released: https://github.com/kubernetes/kubernetes/releases/tag/v1.24.0
We need to add the support for provisioning 1.24 clusters in RKE

TODO:

SURE-3940

@chfrank-cgn
Copy link

The version of cri_dockerd in RKE1 1.23.6 (as bundled in Rancher 2.6.5) has extremely bad performance; just installing an empty RKE1 cluster will max out a 4vCPU VM.

@snasovich
Copy link
Collaborator

Mirantis/cri-dockerd#38 may be related and help address the performance issues.

@jiaqiluo
Copy link
Member Author

jiaqiluo commented Jun 4, 2022

Mirantis/cri-dockerd#38 may be related and help address the performance issues.

In order to use the new version of cri-dockerd, we need to

  1. update https://github.com/rancher/cri-dockerd/ to get the upstream's change , tag a new release update: because the upstream is actively maintained now, we will use the upstream's releases directly instead of building it ourselves
  2. update the version in https://github.com/rancher/rke-tools/blob/ef0a37a04adf865c50f0d115ec0efcd059c7a907/package/Dockerfile#L8 and tag a new image
  3. use the new rke-tool image tag in KDM for 1.24

#2938 is tracking the progress for this problem

@jiaqiluo
Copy link
Member Author

jiaqiluo commented Jun 4, 2022

PR to mirror images: rancher/image-mirror#254

@jiaqiluo jiaqiluo changed the title Add support for provisioning 1.24 clusters RKE - Add support for provisioning 1.24 clusters Jun 7, 2022
@jiaqiluo jiaqiluo changed the title RKE - Add support for provisioning 1.24 clusters RKE - Add support for provisioning 1.24 clusters Jun 7, 2022
@jiaqiluo jiaqiluo mentioned this issue Jun 8, 2022
@jiaqiluo
Copy link
Member Author

jiaqiluo commented Jun 29, 2022

can be tested on v1.3.13-rc2 https://github.com/rancher/rke/releases/tag/v1.3.13-rc2

At least to test:

  • provision a new 1.24 cluster
  • upgrade from a previous version to 1.24
  • set/ unset the enable_cri_dockerd filed in the cluster.yml file:
    • note:it is enabled by default when the cluster version >= 1.24 AND the option enable_cri_dockerd is not configured in the cluster.yml file

@Josh-Diamond
Copy link

Josh-Diamond commented Jul 19, 2022

Test cases and results were tracked and may be found in confluence under:

  • Rancher QA > Test Plans > Kubernetes Version Support > RKE > K8s 1.24 support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants