Make network tunnel default #6873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mook-as
approved these changes
May 13, 2024
Can you file an issue for that; otherwise it will get lost. |
We already have an issue with this on the board. |
This allows the Rancher Desktop to start with network tunnel as a default network. Signed-off-by: Nino Kodabande <nkodabande@suse.com>
Nino-K
force-pushed
the
make-network-tunnel-default
branch
from
828b8db
to
18ce29e
Compare
mook-as
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the Rancher Desktop to start with the network tunnel as a default network. Some e2e tests are expected to fail since there will be a separate PR to address the failing tests. Ideally, this PR should be rebased again once the fixes for failing e2e tests are in place.
Fixes: #6850