Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout all text files with Unix line-endings #6811

Open
jandubois opened this issue May 2, 2024 · 0 comments
Open

Checkout all text files with Unix line-endings #6811

jandubois opened this issue May 2, 2024 · 0 comments
Labels
kind/quality quality improvements, refactoring, Automation via CI, E2E, Integration, CLI or REST API

Comments

@jandubois
Copy link
Member

Right now we specify in .gitattributes:

# All Linux scripts should have LF line endings
# But only text files should be changed (not any binaries / images / etc.)
resources/linux/** text=auto eol=lf
pkg/rancher-desktop/assets/scripts/** text=auto eol=lf

I don't see why we shouldn't do this for all text files instead. This would also simplify our instructions for running BATS on Windows. Alternatively we can just add another rule for bats/**.

May effort here is testing that enabling it globally doesn't break anything.

@jandubois jandubois added the kind/quality quality improvements, refactoring, Automation via CI, E2E, Integration, CLI or REST API label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/quality quality improvements, refactoring, Automation via CI, E2E, Integration, CLI or REST API
Projects
None yet
Development

No branches or pull requests

1 participant