Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve installability of all dependencies #151

Open
dragonchaser opened this issue Apr 29, 2021 · 4 comments
Open

Resolve installability of all dependencies #151

dragonchaser opened this issue Apr 29, 2021 · 4 comments
Projects

Comments

@dragonchaser
Copy link
Contributor

dragonchaser commented Apr 29, 2021

When installing a chart that includes either optional or shared dependencies, make sure that each of them is resolvable and installable. If there is no installable candidate, cancel the whole installation and inform the user.
(This probably overlaps with #139 in some areas)

Implementation
Walk over the whole dependency tree and check if every chart/dependency is available on one of the repos.

@dragonchaser dragonchaser changed the title Resolv instalability of all dependencies Resolve installability of all dependencies Apr 29, 2021
@kkaempf
Copy link
Collaborator

kkaempf commented Apr 29, 2021

Why should an optional dependency matter ?

@kkaempf
Copy link
Collaborator

kkaempf commented Apr 29, 2021

imho, an optional dependency should be similar to a zypper recommends which "are silently dropped if no match is possible."

@dragonchaser
Copy link
Contributor Author

Because it relies on the Install methods of helm and if it is installable is not determined on our side atm, meaning: if the chart is not resolvable it will fail during the installation on the helm-codes side.

@dragonchaser
Copy link
Contributor Author

imho, an optional dependency should be similar to a zypper recommends which "are silently dropped if no match is possible."

Ah ok now I understand, still we need to resolve those on our side before hand, but of course we can drop the optional deps then.

@mattfarina mattfarina added this to To do in Shit It May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Shit It
To do
Development

No branches or pull requests

2 participants