Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upstream] Simplify setting Namespace and ReleaseName #117

Open
viccuad opened this issue Apr 9, 2021 · 0 comments
Open

[Upstream] Simplify setting Namespace and ReleaseName #117

viccuad opened this issue Apr 9, 2021 · 0 comments
Labels
upstream interest in moving this upstream
Projects

Comments

@viccuad
Copy link
Member

viccuad commented Apr 9, 2021

In Helm:
action.Init creates a kubernetes client with a namespace set by a flag or environment variable.
ReleaseName is set by a flag, or by the name of the chart.

In Hypper:
We need to support the previous, plus read the chart annotations to discover if we need to use them. This means that we need to do a back-and-forth: create actions, then read flags and so, then load the chart, then set namespace and release name.

Could we simplify this?

See:
#49 (comment)
#89
#105
(and bugfixes per command, etc)

@viccuad viccuad added the upstream interest in moving this upstream label Apr 9, 2021
@mattfarina mattfarina added this to To do in Shit It May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream interest in moving this upstream
Projects
Shit It
To do
Development

No branches or pull requests

1 participant