Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upstream] Move search out of cmd? #116

Open
Itxaka opened this issue Apr 9, 2021 · 0 comments
Open

[Upstream] Move search out of cmd? #116

Itxaka opened this issue Apr 9, 2021 · 0 comments
Labels
upstream interest in moving this upstream
Projects

Comments

@Itxaka
Copy link
Contributor

Itxaka commented Apr 9, 2021

While implementing the search in hypper we foudn out that most of the code is under cmd for some reason.

As part of the implementation, the relevant code was moved out into a pkg/search as it makes sense to have it there, plus helm does not guarantee that code under cmd will stay, while they will respect the API in pkg.

Maybe we should test the waters upstream to make the change there instead so its more maintainable? Check why the code is in there in the first place?

@Itxaka Itxaka changed the title [Upstream] Move search our of cmd? [Upstream] Move search out of cmd? Apr 9, 2021
@Itxaka Itxaka added the upstream interest in moving this upstream label Apr 9, 2021
@mattfarina mattfarina added this to To do in Shit It May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream interest in moving this upstream
Projects
Shit It
To do
Development

No branches or pull requests

1 participant