Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please version bump pandas in requirements file #1230

Closed
mttpgn opened this issue Dec 10, 2022 · 1 comment
Closed

Please version bump pandas in requirements file #1230

mttpgn opened this issue Dec 10, 2022 · 1 comment

Comments

@mttpgn
Copy link

mttpgn commented Dec 10, 2022

Hello,

Your requirements.txt file allows any version of pandas above 0.24.0.

However, in your utils.py file, you twice invoke the pandas read_csv function with the on_bad_lines argument, an argument which was only introduced in pandas 1.3.0.

As a result, anyone running yfinance with a version of pandas greater than or equal to 0.24.0 but lower than 1.3.0 will experience a crash with the following error:

    df = _pd.read_csv(fp, index_col="Ticker", on_bad_lines="skip")
TypeError: parser_f() got an unexpected keyword argument 'on_bad_lines'

Please bump the version of pandas in your requirements.txt file to say
pandas>=1.3.0

@phnv
Copy link

phnv commented Feb 1, 2023

It would be nice to update requirements to python 3.7+ too, since apparently pandas last version to support python 3.6 is v==1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants