Move get 'trailingPegRatio' into _get_info(), simplify & optimise #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I completely forgot about this! @ValueRaider Why are we setting keys to a set with a string inside, just to check if len(keys) > 0 one line below? |
|
@rickturner2001 Just habit of defensive coding - I made an iterable so check length. No harm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1114, which was caused by redundant code so just removed it.
Move the logic into
_get_info()- I introduced this bug in my big timezone update (#1048), so 'trailingPegRatio' would have disappeared frominfo[].Simplify the code as loop is unnecessary. Also disable it, replacing with a direct GET - scraping a whole page for one variable is a waste. Keep the original code in case do want all key statistics in future.
@rickturner2001 I believe you first requested that 'trailingPegRatio' be fixed (#903).