Fix cache error on read only system #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fredrik-corneliusson - would you mind porting these changes in |
|
Sure, but will probably not have time to work on it today. |
paulmcq
reviewed
Oct 24, 2022
There was a problem hiding this comment.
yfinance/utils.py in get_cache_dirpath:
if _cache_dp is None:
dp = _os.path.join(_ad.user_cache_dir(), "py-yfinance")
else:
dp = _os.path.join(_cache_dp, "py-yfinance")
may be more readable as:
udc = _cache_dp or _ad.user_cache_dir()
dp = _os.path.join(udc, "py-yfinance")
return dp
|
@paulmcq Thanks for reviewing. But I am planning to merge in big changes from |
fredrik-corneliusson
added a commit
to fredrik-corneliusson/yfinance-tz-cache
that referenced
this pull request
Oct 24, 2022
ValueRaider
added a commit
that referenced
this pull request
Oct 25, 2022
Fix cache error on read only system #1108
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silently handle errors in the timezone-cache without stopping execution.
Add
set_tz_cache_location()so user can provide alternative location, in case default not accessible.Resolves issue #1107