Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow input for php executable #75

Open
pkruithof opened this issue Jan 15, 2021 · 3 comments
Open

Allow input for php executable #75

pkruithof opened this issue Jan 15, 2021 · 3 comments

Comments

@pkruithof
Copy link

Not sure if this is even possible or in scope for this action, but we install dependencies inside a Docker container where we also have our required extensions available. We can't use this action with that unfortunately. I think that if you're able to set the php/composer executable that this could work something like this:

- uses: "ramsey/composer-install@v1"
  with:
    php: "docker-compose run --rm php"

The main reason we do it this way is because some packages install different versions depending on the php environment (like Ocramius/ProxyManager if I remember correctly). We could replicate our environment using shivammathur/setup-php of course, but that would mean maintaining our php environment in 2 places.

Is this something you'd consider?

@ramsey
Copy link
Owner

ramsey commented Jan 15, 2021

You're looking to set the php executable or the composer one? Or both?

@pkruithof
Copy link
Author

Good question, I think setting the composer executable should be enough. Then again being able to set the php executable is maybe a more portable solution. I'm not sure.

@ramsey
Copy link
Owner

ramsey commented Dec 24, 2021

Quick update... I'll be adding php-path and composer-path input parameters, so you can set one or the other, or both. Expect to see this in (maybe) version 2.1.0.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants