Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: version update for codecov action runner #226

Merged
merged 1 commit into from Apr 5, 2022

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Apr 5, 2022

Description

Yet another predefined action has had a major release.

This is, again, mostly just a change of the Node version used by the action itself (from Node 12 to Node 16).

Refs:


@ramsey As an alternative to these kind of (manual) PRs, I'd be happy to add a Dependabot configuration which will create these type of PRs automatically.

Motivation and context

General maintenance.

How has this been tested?

Will automatically be tested via the GH Actions run.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.

Yet another predefined action has had a major release.

This is, again, mostly just a change of the Node version used by the action itself (from Node 12 to Node 16).

Refs:
* https://github.com/codecov/codecov-action/releases
@jrfnl jrfnl requested a review from ramsey as a code owner April 5, 2022 22:04
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #226 (4f754e8) into v2 (e3612f6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               v2     #226   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files           5        5           
  Lines         117      117           
=======================================
  Hits          115      115           
  Misses          2        2           

@ramsey
Copy link
Owner

ramsey commented Apr 5, 2022

As an alternative to these kind of (manual) PRs, I'd be happy to add a Dependabot configuration which will create these type of PRs automatically.

Yes, please! 😄

@Ocramius added this to ramsey/uuid, and I was going to try to see if it would work here, too, but I hadn't gotten to it, yet. I appreciate your help! https://github.com/ramsey/uuid/blob/4.x/.github/workflows/merge-dependabot-upgrades.yml

@ramsey ramsey merged commit 69e970d into ramsey:v2 Apr 5, 2022
@jrfnl jrfnl deleted the feature/ghactions-update-codecov branch April 5, 2022 23:10
@jrfnl
Copy link
Contributor Author

jrfnl commented Apr 5, 2022

@ramsey Looks like what @Ocramius added is not the actual configuration, but a way to automatically merge the pull requests from Dependabot. I'm a bit wary of automated merges, so let me for now just pull the config for you and then you can decide on the auto-merge workflow separately.

@jrfnl
Copy link
Contributor Author

jrfnl commented Apr 5, 2022

@ramsey See PR #227

@Ocramius
Copy link
Sponsor

Ocramius commented Apr 6, 2022

I'm a bit wary of automated merges,

Mostly depends on test confidence - not viable on some projects, but if you have a very detailed QA suite, you can do this.

@jrfnl
Copy link
Contributor Author

jrfnl commented Apr 6, 2022

@Ocramius Hear hear! Unfortunately the majority of projects I work on does not have that, so yeah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants