Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Screens system #147

Closed
wants to merge 20 commits into from
Closed

Conversation

Jeremi360
Copy link
Contributor

Adds "show", "hide", "at" and "with" keywords to RKScript and Screen nodes.
This implements #143

@Jeremi360 Jeremi360 self-assigned this Feb 13, 2023
@Jeremi360 Jeremi360 added enhancement New feature or request code Changes in how Rakugo core works rks_extension extension for RakuScript labels Mar 1, 2023
@Jeremi360 Jeremi360 added this to the 1.0 milestone Mar 1, 2023
@Jeremi360 Jeremi360 linked an issue Mar 1, 2023 that may be closed by this pull request
18 tasks
@theludovyc
Copy link
Contributor

Hello :)

I will not review 2761 files with +91,863 −31 updates.

Please say me the files you want I see, or merge it if you are confident :)

@Jeremi360
Copy link
Contributor Author

Jeremi360 commented Aug 1, 2023

Hello :)

I will not review 2761 files with +91,863 −31 updates.

Please say me the files you want I see, or merge it if you are confident :)

@theludovyc This is not ready for review/merge as it doesn't work as it should.
The biggest problem I have is that I have on helper object BaseScreen.gd,
so I can easy you the same code for Node2D as for Control.
But for some reason it works for Node2D, but not for Control.
See scripts: Screen.gd and Screen2D.gd
Screens are added to Rakugo Scripting by Screens.gd singleton.
There is res://game/ScreensExample.tscn scene that I use for testing Screens visually.

@Jeremi360 Jeremi360 closed this Jun 9, 2024
@Jeremi360
Copy link
Contributor Author

We no longer work on 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Changes in how Rakugo core works enhancement New feature or request rks_extension extension for RakuScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screens and keywords
2 participants