Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change with output location with 1.1.2 #194

Closed
ankane opened this issue Dec 7, 2021 · 6 comments
Closed

Breaking change with output location with 1.1.2 #194

ankane opened this issue Dec 7, 2021 · 6 comments

Comments

@ankane
Copy link

ankane commented Dec 7, 2021

Hi, it looks like the latest release introduces a breaking change with the output location.

Rake::ExtensionTask.new("field_test") do |ext|
  ext.name = "ext"
  ext.lib_dir = "lib/field_test"
end

Previously, this created lib/field_test/ext.bundle, but now it creates lib/field_test/field_test/ext.bundle.

@kou
Copy link
Member

kou commented Dec 7, 2021

Oh... This should be fixed and we should release a new version.

@kou
Copy link
Member

kou commented Dec 7, 2021

Could you show a project that uses this configuration?

@kou
Copy link
Member

kou commented Dec 7, 2021

#191 may be related.

@ankane
Copy link
Author

ankane commented Dec 7, 2021

Hey @kou, thanks for the fast response! Here's the project / setup instructions.

@kou
Copy link
Member

kou commented Dec 7, 2021

Thanks.
I've fixed this and released a new version.

@ankane
Copy link
Author

ankane commented Dec 8, 2021

Works great, thank you @kou! And thanks for this awesome project!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants