-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release with Ruby 2.7 support? #30
Comments
Interested too - been following along the recent changes in both projects and ruby/ruby#2772 |
@apolcyn I'm about to release rake-compiler-dock-1.0.0. It adds ruby-2.7, but the big change is the use of dedicated docker images per cross build target. So there are 4 MRI images currently and one for JRuby. They share common docker layers where possible to avoid increased download sizes. I'll document that in the CHANGELOG. I would like to incorporate the changes of your Dockerfile into rake-compiler-dock since they are possibly useful for others. Line 8 seems to be superfluous since this is already installed in the base image. The switch to pthread could be interesting for other projects as well. Is there any drawback in using them? I'm uncertain, what the I didn't find a description of how to build grpc fat binary gems locally and didn't try anything so far. Is it difficult? |
cc @nicolasnoble and @veblush
@larskanis the grpc binary packages can be built locally with the following steps:
|
The various |
@larskanis I've been using rake-compiler for many years and rake-compiler-dock for almost a year and let it be known that X compiling and fat gem distributions is a HARD problem. 👏 for packaging it into an easy to use solution AND maintaining it very well |
I added all changes from the grpc Dockerfile to rake-compiler-dock-1.0.0 except the rename of gettimeofday(). I guess there's some conflict with this method, but I don't want to change the public API of Ruby. Moreover this function is used by the pg.gem. I think there's probably another way to fix this issue for grpc or to apply the change in the RakeCompilerDock.sh call. Another questionable change for me is the rename of As discussed above, rake-compiler-dock-1.0.0 has some changes to the rake tasks that are described in the README. You can have a look into pg gem or fxruby or nokogiri, how these changes look, if you're intend to use the parallel build feature. |
There is no feasible way to use C++ thread-related standard library such as mutex on mingw except using pthreads-win32. It may introduce a bit of overhead due to a wrapping layer between this but it only happens when using those libraries, I believe. |
OK, support for ruby-2.7 is out since 3 months and grpc.gem is running well with rake-compiler-dock-1.0 (as far as I know). I'll check at future releases that grpc still works. Closing this issue now. |
For the "grpc" gem, we currently use a rake-compiler-dock docker image as a base for a slightly customized dockerfile, see https://github.com/grpc/grpc/blob/c4f80b8c877e3ecf259c4da3e8f6be06e1ff8450/third_party/rake-compiler-dock/Dockerfile
To add ruby 2.7 support to grpc (grpc/grpc#21514), it would be convenient to use a published rake-compiler-dock image which has add ruby 2.7 cross compiling support.
Just wondering plans/timelines for the next rake-compiler-dock release with ruby 2.7 support
The text was updated successfully, but these errors were encountered: