From b1282ff318547dcfb1e380d64dd78f71daab9c1a Mon Sep 17 00:00:00 2001 From: Mihai Codoban Date: Tue, 27 Apr 2021 08:24:27 -0700 Subject: [PATCH] Add binding redirects for all assemblies redistributed by MSBuild (#6334) MSBuild redistributes System.Memory but does not binding redirect it. This causes the QB cache plugin to fail (qb.exe works because it has binding redirects, but the plugin fails because it's a dll and dlls don't have binding redirects). Both MSBuild and VS ship with System.Memory 4.0.1.1 so this should not have any negative consequences. --- eng/Packages.props | 4 +++ src/MSBuild/app.amd64.config | 53 ++++++++++++++++++++++++++++++++++++ src/MSBuild/app.config | 53 ++++++++++++++++++++++++++++++++++++ 3 files changed, 110 insertions(+) diff --git a/eng/Packages.props b/eng/Packages.props index 91058315eaa..d6917bd7207 100644 --- a/eng/Packages.props +++ b/eng/Packages.props @@ -1,4 +1,8 @@ + diff --git a/src/MSBuild/app.amd64.config b/src/MSBuild/app.amd64.config index 0a80738b202..c628bb06c2d 100644 --- a/src/MSBuild/app.amd64.config +++ b/src/MSBuild/app.amd64.config @@ -47,11 +47,64 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/src/MSBuild/app.config b/src/MSBuild/app.config index 2dff0102225..3eee42f2426 100644 --- a/src/MSBuild/app.config +++ b/src/MSBuild/app.config @@ -41,11 +41,64 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +