Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace mem with fast-memoize #919

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Jul 12, 2021

mem pulls in a few levels deep of dependencies for something pretty simple.

here i've replaced it with fast-memoize which has no dependencies and seems much faster/simpler.

let me know if you want any changes

FYI the default serializer is JSON.stringify internally so the cache will be keyed by the stringified args afaict (equivalent of before, almost)

@raineorshine
Copy link
Owner

raineorshine commented Jul 12, 2021

Looks good! Thank you!

@raineorshine raineorshine merged commit 4ea1368 into raineorshine:main Jul 12, 2021
@43081j 43081j deleted the memoize branch July 12, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants