Add sort-destructure-keys #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RNBW-1870 Add sort-destructure-keys to eslint-config-rainbow
@jin requested we add sort-destructure-keys to eslint-config-rainbow. sgtm! It will be a major change on the config, and we should land large PRs first. |
jinchung
reviewed
Nov 17, 2021
bcomnes
force-pushed
the
bret/rnbw-1870-add-sort-destructure-keys-to-eslint
branch
from
5c0bb90
to
7dca224
Compare
bcomnes
deleted the
bret/rnbw-1870-add-sort-destructure-keys-to-eslint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds https://github.com/mthadley/eslint-plugin-sort-destructure-keys#readme.
It will be a breaking change, but the good news is it supports the --fix flag, so it can be automatically fixed.
We should wait to land any outstanding large PRs before upgrading dependents.