Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .(sass|scss).erb #2259

Merged
merged 1 commit into from Sep 18, 2019
Merged

Support .(sass|scss).erb #2259

merged 1 commit into from Sep 18, 2019

Conversation

swrobel
Copy link
Contributor

@swrobel swrobel commented Aug 28, 2019

@gauravtiwari maybe I'm misunderstanding your comment, but it seems that the erb loader forces itself to the front of the loader chain (I checked my loaders and it is first) but the sass loader still needs to be ok with the fact that the file might end with .erb

@@ -1,6 +1,6 @@
const getStyleRule = require('../utils/get_style_rule')

module.exports = getStyleRule(/\.(scss|sass)$/i, false, [
module.exports = getStyleRule(/\.(scss|sass)(\.erb)?$/i, false, [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, did you test the regex? /\.(scss|sass)?(\.erb)?$/ (optional .erb ext) I am no expert but feel like this is correct.

@gauravtiwari gauravtiwari merged commit dcd9cd1 into rails:master Sep 18, 2019
@gauravtiwari
Copy link
Member

Just tested, this one looks fine too :) Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants