avoid asset_path route helper collisions #2511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a Rails application has an `assets` route resource, than the generated `asset_path` route helper will override the asset helper of the same name. Rails provides the aliases `path_to_asset` and `url_to_asset` to avoid this, and uses them internally. We can do the same here.
granth
commented
Mar 25, 2020
| # Returns the relative path using manifest.json and passes it to asset_path helper. | ||
| # This will use asset_path internally, so most of their behaviors will be the same. | ||
| # Returns the relative path using manifest.json and passes it to path_to_asset helper. | ||
| # This will use path_to_asset internally, so most of their behaviors will be the same. |
There was a problem hiding this comment.
I dithered on whether to rename the method in the comments, too, since path_to_asset is probably not as well known as asset_path. I thought it was better to be consistent.
|
thanks @granth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Rails application has an
assetsroute resource, than the generatedasset_pathroute helper will override the asset helper of the same name.Rails provides the aliases
path_to_assetandurl_to_assetto avoid this, and uses them internally. We can do the same here.