Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #2360

Merged
merged 3 commits into from Nov 12, 2019
Merged

Update dependencies #2360

merged 3 commits into from Nov 12, 2019

Conversation

gauravtiwari
Copy link
Member

Updates gem and npm dependencies

@gauravtiwari gauravtiwari added the WIP This PR is work in progress label Nov 11, 2019
@gauravtiwari gauravtiwari removed the WIP This PR is work in progress label Nov 12, 2019
@gauravtiwari gauravtiwari merged commit 13756f1 into master Nov 12, 2019
@gauravtiwari gauravtiwari deleted the upgrade-deps branch November 12, 2019 07:49

const isEmpty = value => value === null || value === undefined
const isEmpty = (value) => value === null || value === undefined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@javan @jakeNiemiec @gauravtiwari What do you guys think about separating linting updates (eslint and rubocop) from other updates?

The "blame" of files makes more sense if this is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants