Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@import statements (such as those used for google fonts aren't positioned at the top of the css) #785

Open
akaspick opened this issue Apr 16, 2023 · 1 comment

Comments

@akaspick
Copy link

Expected behavior

When using Sprockets 3.x, any @import statements used for @import'ing other css would be placed at the top of the compiled css. This is required according to the spec: https://developer.mozilla.org/en-US/docs/Web/CSS/@import

An @import rule must be defined at the top of stylesheet, before any other at-rule (except @charset and @layer) and style declaration, else it will be ignored.

Actual behavior

Using Sprockets 4, the @import statements are left in the location they are found in the file compilation order, so they can end up anywhere in the final compiled CSS.

System configuration

  • Sprockets version 4.20
  • Ruby version 3.2.1
@akaspick
Copy link
Author

akaspick commented Apr 17, 2023

So my only possible solution so far is to include the @import statement in my app/assets/stylesheets/application.css after all the usual comments and putting the require_self call before any other require statements.

ie.

 /*
 *= require_self
 *= require_tree ./site
 */

@import url(//fonts.googleapis.com/css?family=Open+Sans+Condensed:300,700);

I used to be able to put the @import in any of the scss files in ./site and the resulting .css would put the @import at the beginning of the compiled css.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant