[Backport] Fixnum and Bignum are deprecated on Ruby trunk #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no reason to use different markers for Fixnum and Bignum anyway, so unify them to Integer: our version change already bumps the digest.
Forgot to put this in the original backport commit 😬
|
Thanks! Can you add another commit to add 2.4 to the travis matrix for this branch? |
|
👍 updated @schneems, Travis is green |
|
thanks! |
|
👍 no problem @schneems; is it possible to get this released in a v3.7.1 of Sprockets? |
|
Done |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports #392 to the
3.xbranch, which is still the default Sprockets release line used by Rails. This is one of the last code changes required to get Rails' test suite passing on Ruby v2.4.0-rc1. It would be amazing if a new release of Sprockets could be put out with this patch in it ❤️ ❤️cc @schneems