Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache_key to BabelProcessor #387

Merged
merged 1 commit into from Sep 27, 2016

Conversation

rmacklin
Copy link
Contributor

@rmacklin rmacklin commented Sep 23, 2016

This ensures the cache will be invalidated if BabelProcessor's options are changed. (See this test.)

This ensures the cache will be invalidated if the options are changed.
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @arthurnn (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rmacklin
Copy link
Contributor Author

cc @schneems

@schneems
Copy link
Member

Thanks!

@schneems schneems merged commit 55b8c83 into rails:master Sep 27, 2016
@rmacklin rmacklin deleted the add-cache-key-to-babel-processor branch December 22, 2016 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants