Explicit API to error when an asset is not found #379
Merged
+36
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal here is that we can eventually extend this to look for common problems. For example in the future if you try to load `asset_path(assets/javascripts/application.js)` you might get an error telling you that you that you should leave off the paths in front of the asset. We could also look for assets with the same name and different file extensions as well as do a `did you mean` type levenshtein lookup for possible asset mis-spellings. We can't do any of that today because there is no guarantee that you expect `find_asset` to return a valid result. By introducing an explicit api `find_asset!` we can guarantee the user either wants an asset or an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is that we can eventually extend this to look for common problems. For example in the future if you try to load
asset_path(assets/javascripts/application.js)you might get an error telling you that you that you should leave off the paths in front of the asset. We could also look for assets with the same name and different file extensions as well as do adid you meantype levenshtein lookup for possible asset mis-spellings.We can't do any of that today because there is no guarantee that you expect
find_assetto return a valid result. By introducing an explicit apifind_asset!we can guarantee the user either wants an asset or an error.