Backport #331 - Asset lookup 4x Faster in large directories #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
schneems
force-pushed
the
schneems/fix-asset-lookup-perf-3.x
branch
from
2cdaaec
to
4955eff
Compare
schneems
changed the title
With this patch using the benchmark script https://github.com/schneems/sprockets-3.x-performance-regressions: ``` 1500 lookups of the same asset took 2.900005 1500 lookups of 1500 different assets took 2.746331 ``` Without this patch using the benchmark script: ``` 1500 lookups of the same asset took 12.361615 1500 lookups of 1500 different assets took 12.627099 ``` Which is a 4x speed bump.
schneems
force-pushed
the
schneems/fix-asset-lookup-perf-3.x
branch
2 times, most recently
from
ee62440
to
a591ab7
Compare
- Rack < 2.0 for Ruby < 2.2.2 - Json < 2.0 for Ruby < 2.0
schneems
force-pushed
the
schneems/fix-asset-lookup-perf-3.x
branch
from
a591ab7
to
f2e3623
Compare
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch using the benchmark script https://github.com/schneems/sprockets-3.x-performance-regressions:
Without this patch using the benchmark script:
Which is a 4x speed bump.