Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to github actions #475

Merged
merged 2 commits into from Jun 23, 2021
Merged

Conversation

hahmed
Copy link
Contributor

@hahmed hahmed commented Jun 17, 2021

What

Move to GitHub actions and drop TravisCI.

Anything else

I have split into 2 commits, 1 for the build (which is currently failing on travis ci) and the other for the test fixes, but let me know if you want me to squash into 1 commit.

The GitHub actions are not being run here, but you can see them all green here https://github.com/hahmed/sprockets-rails/actions/runs/952618642 -- not sure why I can see the actions workflow on my fork but not upstream, but @byroot mentioned if we merged this PR we would prob see the actions here too.

Should we consider updating the target ruby version in a follow up PR, perhaps ruby 2.7?

@hahmed hahmed marked this pull request as ready for review June 17, 2021 21:40
@hahmed hahmed marked this pull request as draft June 17, 2021 21:40
@hahmed hahmed marked this pull request as ready for review June 17, 2021 21:43
@hahmed hahmed marked this pull request as draft June 17, 2021 21:44
@hahmed hahmed marked this pull request as ready for review June 17, 2021 23:04
@hahmed hahmed marked this pull request as draft June 17, 2021 23:04
@hahmed hahmed marked this pull request as ready for review June 18, 2021 21:06
…he rails version and appends media="screen" to the assertions. The setting config.action_view.apply_stylesheet_media_default = true was added in rails 7.

The method signature for ActionView::Base.new requires a couple of extra params which was also needed to get the build to pass.
@hahmed
Copy link
Contributor Author

hahmed commented Jun 19, 2021

fyi... rack/rack#1755 reverts Flatten Rack::Request::Env into Request we could target the maser branch for Rack once that get's merged.

@rafaelfranca rafaelfranca merged commit 118ce60 into rails:master Jun 23, 2021
@hahmed hahmed deleted the ha/move-to-gitub-actions branch June 23, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants