Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis-ci: remove unsupported rubies and rails versions #469

Merged
merged 2 commits into from Oct 7, 2020

Conversation

skatkov
Copy link
Contributor

@skatkov skatkov commented Sep 27, 2020

Removing some unsupported stuff from travis ci matrix - rubies and rails.

Based on a comment shared by @schneems in #468 (comment)

@schneems
Copy link
Member

schneems commented Oct 6, 2020

I don't think we can kill off 5.1 support just yet until Rails 6.1 comes out.

I'm also not totally sure what repercussions this will have in terms of maintenance policy. Basically: rails versions don't declare a dependency on sprockets, they declare it on sprockets-rails. I would normally say that if we're dropping support, we should consider branching this gem so 4.x would be the version that has support dropped for these older rubies and rails versions, and 3.x could possibly live around as a best-effort, minimially supported thing if the process causes havoc and/or other core memebers need something in an older version.

@rafaelfranca
Copy link
Member

I don't think we can kill off 5.1 support just yet until Rails 6.1 comes out.

Yes, we can. Only Rails 5.2 and 6.0 are currently supported.

I don't think we need to release a major version of sprockets-rails just to drop support to old Rails version. We only need to update the sprockets-rails.gemspec to not allow it being installed in any Rails < 5.2.

@skatkov
Copy link
Contributor Author

skatkov commented Oct 7, 2020

Agree with @rafaelfranca. Not sure why we can't drop 5.1, since only 5.2 and 6.0 are supported now.

I also updated gemspec.

@schneems
Copy link
Member

schneems commented Oct 7, 2020

Only Rails 5.2 and 6.0 are currently supported.

Right, sorry. I got the Rails support policy (2 releases) and Ruby (3 releases) mixed up in my head. Thanks for the clarification. I've been away from github.com/rails for too long 😅

Thanks for the work here!

@schneems schneems merged commit 1a0cf7a into rails:master Oct 7, 2020
@skatkov skatkov deleted the travis-remove-unsupported-versions branch October 8, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants