Revert #5861 #5896
Merged
Revert #5861 #5896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9b14e3f.
|
We need to feature-detect and prefer the new API rather than show deprecation warnings our users can't do anything about. The warnings are for us, users of the multi_json lib, not everyone who invokes a Rails 3.2 command and wonders why it's squawking at them. |
|
Good call! |
|
👍 |
|
Thanks @sferik! |
jeremy
added a commit
that referenced
this pull request
Apr 21, 2012
Revert #5861. Feature-detect which MultiJson API to use.
AlexRiedler
pushed a commit
to AlexRiedler/rails
that referenced
this pull request
Jan 9, 2013
Revert rails#5861. Feature-detect which MultiJson API to use. Conflicts: activesupport/activesupport.gemspec This backports multi_json version depedency changes as applied. Rationale: rails#5861 Patch by sferik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9b14e3f.
Rationale: #5861 (comment)