Fix cookie domain for domain: all on two letter single level TLD
#47087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
works for me! |
jhawthorn
changed the title
domain: all on two letter single level TLD
jhawthorn
force-pushed
the
cookie_domain
branch
from
1146451
to
941e0cd
Compare
jhawthorn
added a commit
that referenced
this pull request
Jan 25, 2023
Fix cookie domain for `domain: all` on two letter single level TLD
jhawthorn
added a commit
that referenced
this pull request
Jan 25, 2023
Fix cookie domain for `domain: all` on two letter single level TLD
WhatTheAncient
pushed a commit
to WhatTheAncient/rails
that referenced
this pull request
Feb 11, 2023
Fix cookie domain for `domain: all` on two letter single level TLD
bendilley
pushed a commit
to skillstream/rails
that referenced
this pull request
Feb 24, 2023
Fix cookie domain for `domain: all` on two letter single level TLD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the regex wasn't checking for a
.before the TLDs, so would incorrectly match on single-level two-letter TLDs.This should (hopefully) fix #47055 and restore the previous behaviour (though possibly that behaviour isn't 1000% correct vs comparing against the public suffix list, but hopefully it's good enough™)