Fix disabling strict_loading when enabled by default #45018
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When
strict_loading
is enabled by default, trying to explicitly disable strict loading at the relation level doesn't work:This PR ensures that
.strict_loading(false)
results in records which don't strictly load, even when enabled by default.Other Information
Use-case: in an app with strict loading globally enabled (
config.active_record.strict_loading_by_default = true
), there's some contexts (noodling around in a Rails console, say) where you want a quick escape hatch.