Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #38957 #44287

Merged
merged 2 commits into from Jan 29, 2022
Merged

Revert #38957 #44287

merged 2 commits into from Jan 29, 2022

Conversation

gmcgibbon
Copy link
Member

@gmcgibbon gmcgibbon commented Jan 28, 2022 •
edited

Summary

Reverts #38957, #43650

The feature is being rewritten. Proceeding with the revert as discussed in #43971.

@gmcgibbon gmcgibbon mentioned this pull request Jan 28, 2022
Closed
@p8 p8 mentioned this pull request Jan 29, 2022
Closed
@dhh dhh merged commit aaa6468 into rails:main Jan 29, 2022
dhh pushed a commit that referenced this pull request Jan 29, 2022
@gmcgibbon @dhh
Revert #38957 (#44287)
1711f98 
* Revert "Pass service_name param to DirectUploadsController"

This reverts commit 193289d.

* Revert "Multi-service direct uploads in Action Text attachment uploads"

This reverts commit 0b69ad4.
@gmcgibbon gmcgibbon deleted the revert_38957 branch January 29, 2022 15:58
@jcoyne jcoyne mentioned this pull request Jan 31, 2022
Merged
@brenogazzola brenogazzola mentioned this pull request Jan 31, 2022
Closed
@ghiculescu ghiculescu mentioned this pull request Feb 9, 2022
Closed
public-rant pushed a commit to opensource-rant/rails that referenced this pull request Feb 17, 2022
@gmcgibbon @public-rant
Revert rails#38957 (rails#44287)
cd35aec 
* Revert "Pass service_name param to DirectUploadsController"

This reverts commit 193289d.

* Revert "Multi-service direct uploads in Action Text attachment uploads"

This reverts commit 0b69ad4.
@imustafin imustafin mentioned this pull request Mar 3, 2022
Merged
8 tasks
@miquelbarba miquelbarba mentioned this pull request Aug 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
actiontext actionview activestorage docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gmcgibbon @dhh