Use the lookup_context to find the correct template path #42437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HParker
force-pushed
the
digest-find-parent-controller-template
branch
from
9d2f41a
to
3044fd7
Compare
This replaces the controller/action method of finding a path with the lookup_context which should always find the same thing as the render method finds.
HParker
force-pushed
the
digest-find-parent-controller-template
branch
from
3044fd7
to
26259b0
Compare
zzak
approved these changes
Jun 10, 2021
lfalcao
reviewed
Jun 10, 2021
| @@ -44,7 +44,7 @@ def determine_template_etag(options) | |||
| # template digest from the ETag. | |||
| def pick_template_for_etag(options) | |||
| unless options[:template] == false | |||
| options[:template] || "#{controller_path}/#{action_name}" | |||
| options[:template] || lookup_context.find_all(action_name, _prefixes).first&.virtual_path | |||
There was a problem hiding this comment.
Why not lookup_context.find(action_name, _prefixes).virtual_path ? 🤔
There was a problem hiding this comment.
find will raise an error if it doesn't find the template. I don't think we want to raise here since we didn't raise before. It fails a lot of actionpack tests that don't have templates but ask about the etag.
Maybe it would be worth switching to find? should we raise if it can't find the template you want as part of your etag? That would be new behavior, but might help people find problems with their cache keys? I am unsure.
There was a problem hiding this comment.
@HParker I would avoid trying to solve problems people aren't experiencing, this PR already adds enough value IMO ❤️
lfalcao
approved these changes
Jun 10, 2021
rafaelfranca
added a commit
that referenced
this pull request
Jun 23, 2021
…template Use the lookup_context to find the correct template path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the controller/action method of finding a path with the lookup_context which should always find the same thing as the render method finds.
Closes: #42417