Handle nil key for MemCacheStore#normalize_key #41376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
added a commit
that referenced
this pull request
Feb 9, 2021
Handle nil key for MemCacheStore#normalize_key
rafaelfranca
reviewed
Feb 9, 2021
| if key | ||
| key = key.dup.force_encoding(Encoding::ASCII_8BIT) | ||
| key = key.gsub(ESCAPE_KEY_CHARS) { |match| "%#{match.getbyte(0).to_s(16).upcase}" } | ||
| key = "#{key[0, 213]}:md5:#{ActiveSupport::Digest.hexdigest(key)}" if key.size > 250 |
There was a problem hiding this comment.
you change here the key format back to md5. Next time please make sure the patch is up-to-date
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41352
There is already an existing test case for this
rails/activesupport/test/cache/behaviors/cache_store_behavior.rb
Lines 113 to 117 in 8db3fef
But it passed for memcached because of
@store.silence!and the relevant branch with a bug was skipped.