Fix raw params method to not raise an exception #41280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you squash commits into one? https://guides.rubyonrails.org/contributing_to_ruby_on_rails.html#squashing-commits |
Prevent the raw_params method from throwing an exception if the argument auth is blank. Add tests for the raw_params method Fix typo Fix rubocop offenses
kentakag
force-pushed
the
fix-raw-params-method-to-not-raise-an-exception
branch
from
eeddee2
to
d7516f4
Compare
kamipo
added a commit
that referenced
this pull request
Feb 1, 2021
…raise-an-exception Fix raw params method to not raise an exception Fixes #41279.
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#41279
Starting from 6.1.1, ActionController::HttpAuthentication::Token::ControllerMethods#authenticate_with_http_token can raise an exception.
It happens when the http authorization request header has only a type and no credential.
Under 6.1.1, nil is returned in such a case.
As a specification, I think it is correct to return nil instead of an exception when the token is invalid.
Therefore, I fixed ActionController::HttpAuthentication::Token#raw_params which raises an exception.
Other Information
In addition, I fixed the typo.
61a9c13