Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove nokogiri dependency #41016

Closed
LeFnord opened this issue Jan 5, 2021 · 3 comments
Closed

remove nokogiri dependency #41016

LeFnord opened this issue Jan 5, 2021 · 3 comments

Comments

@LeFnord
Copy link

LeFnord commented Jan 5, 2021

Are any plans to remove nokogiri as dependency?

After upgrading to nokogiri 1.11.0, again failures are popping up, this happenes allways to this gem.
I t seems it is one of the most failure introducing gem in the rails eco-system.

On the other hand, never seen it in direct usage on project level – have seen many projects in about 15y of rails dev, so it seems it is only a rails internal dependency.

Can somebody give a starting point, so somebody – beste me ;) – can start and make a PR.

Thanks

@eileencodes
Copy link
Member

No, there are no plans to remove Nokogiri. It is used in parts of the framework and there isn't another gem that does the same things.

@LeFnord
Copy link
Author

LeFnord commented Jan 5, 2021

mmh … unter "open mind" versteh da schon was anderes, so'ne barsche absage – nich mal nen Ansatz – ist de facto schon arg unhöflich (help)

@eileencodes
Copy link
Member

eileencodes commented Jan 5, 2021

It's not rude to answer your question directly. I'm sorry if you felt dismissed but the framework requires nokogiri, removing it is not trivial nor do we have plans for it. Additionally every application I have ever worked on uses nokogiri so it's not a transitive dependency of Rails. If you have broken code in your application please open an issue on the nokogiri repo to report a bug.

The nokogiri upgrade was reverted for Rails in #41017 and we opened an issue on nokogiri to discuss sparklemotion/nokogiri#2168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants