Clarify use of rescue_from [ci skip] #40984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rescue_from` works for rescuing exceptions in controller actions, but it's not specific to ActionController. This change updates the docs to clarify the specifics of how `rescue_from` is used and that its use goes beyond controller actions. Note: I believe the original addition of this documentation was added as part of the move from [`ActionController::Rescue` to `ActiveSupport::Rescuable`](rails@259a7a8#diff-2276a3674b84e1262c94cc36346f9fbd8d00e0a4542bb991a8846c06d86335b1R12)
rafaelfranca
added a commit
that referenced
this pull request
Dec 30, 2020
…able-docs Clarify use of rescue_from [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
rescue_fromworks for rescuing exceptions in controller actions, but it's not specific to ActionController.This change updates the docs to clarify the specifics of how
rescue_fromis used and that its use goes beyond controller actions.Other Information
Note: I believe the original addition of this documentation was added as part of the move from
ActionController::RescuetoActiveSupport::Rescuable